From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ido Schimmel Subject: Re: [PATCH net-next 4/4] bridge: vlan: combine (br|nbp)_vlan_flush into one Date: Mon, 12 Oct 2015 21:27:13 +0300 Message-ID: <20151012182713.GA17416@colbert.mtl.com> References: <1444650069-32572-1-git-send-email-razor@blackwall.org> <1444650069-32572-5-git-send-email-razor@blackwall.org> <20151012175156.GA16784@colbert.mtl.com> <20151012181539.GA30057@ketchup.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: Nikolay Aleksandrov , , , , , , , , "Nikolay Aleksandrov" To: Vivien Didelot Return-path: Received: from mail-am1on0083.outbound.protection.outlook.com ([157.56.112.83]:61312 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751675AbbJLS1Z (ORCPT ); Mon, 12 Oct 2015 14:27:25 -0400 Content-Disposition: inline In-Reply-To: <20151012181539.GA30057@ketchup.lan> Sender: netdev-owner@vger.kernel.org List-ID: Mon, Oct 12, 2015 at 09:15:39PM IDT, vivien.didelot@savoirfairelinux.com wrote: >Hi, > >On Oct. Monday 12 (42) 08:51 PM, Ido Schimmel wrote: >> Mon, Oct 12, 2015 at 02:41:09PM IDT, razor@blackwall.org wrote: >> >From: Nikolay Aleksandrov >> > >> >As Ido Schimmel pointed out the vlan_vid_del() loop in nbp_vlan_flush is >> >unnecessary (and is actually a remnant of the old vlan code) so we can >> >remove it and combine both br/nbp vlan_flush functions into one. >> Just a small note to Scott and Vivien: >> >> One of the side effects of Nik's recent patchsets is that when VLANs are >> flushed on a port the deletion is propagated to the driver via >> switchdev ops, as __vlan_vid_del is called. >> >> Therefore there is no need to do internal bookkeeping and remove VLANs >> yourself when port is removed from bridge. > >I was thinking about caching VLAN entries in the mv88e6xxx driver to >improve look up on VLAN and FDB operations, but it's a bit prematurate. > >But when VLAN are flushed, we still need to remove them from the >hardware table, right? Hi, Not sure I'm following. You'll simply get a SWITCHDEV_OBJ_ID_PORT_VLAN (del) for each VLAN configured on the port you just removed from the bridge. I guess you remove them from your hardware table in the implementation of these ops? > >Flushing is interesting though, most hardware have flush operations and >it would be interesting to have switchdev fdb_flush and vlan_flush ops. > >Thanks! >-v