From: Geliang Tang <geliangtang@163.com>
To: David Miller <davem@davemloft.net>, Don Fry <pcnet32@frontier.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Geliang Tang <geliangtang@163.com>
Subject: Re: [PATCH] pcnet32: fix a logic error with pci_set_dma_mask
Date: Tue, 13 Oct 2015 00:53:10 -0700 [thread overview]
Message-ID: <20151013075310.GA3705@ubuntu> (raw)
In-Reply-To: <20151012.053814.1870650163021801761.davem@davemloft.net>
On Mon, Oct 12, 2015 at 05:38:14AM -0700, David Miller wrote:
> From: Geliang Tang <geliangtang@163.com>
> Date: Fri, 9 Oct 2015 03:45:39 -0700
>
> > pcnet32 can't work on my machine recently. It says "architecture
> > does not support 32bit PCI busmaster DMA". There is a logic error
> > in it: pci_set_dma_mask() return 0 means return successfully.
> >
> > Signed-off-by: Geliang Tang <geliangtang@163.com>
>
> This driver doesn't call pci_set_dma_mask() in any of my tree(s).
This patch is against linux-next tree. It was introduced by commit
9c034d4 'pcnet32: use pci_set_dma_mask insted of pci_dma_supported'.
next prev parent reply other threads:[~2015-10-13 7:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 10:45 [PATCH] pcnet32: fix a logic error with pci_set_dma_mask Geliang Tang
2015-10-12 12:38 ` David Miller
2015-10-13 7:53 ` Geliang Tang [this message]
2015-10-22 4:01 ` Don Fry
2015-11-24 4:05 ` Geliang Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151013075310.GA3705@ubuntu \
--to=geliangtang@163.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pcnet32@frontier.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).