From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Brandeburg Subject: Re: [PATCH] i40evf: fix 32 bit build warnings Date: Tue, 13 Oct 2015 12:25:10 -0700 Message-ID: <20151013122510.0000429f@unknown> References: <6607276.TY67sbLLqL@wuerfel> <1444717101.2870.16.camel@intel.com> <57023416.17EujnXPCo@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Jeff Kirsher , , , , Andrew Bowers , Shannon Nelson , Carolyn Wyborny , Don Skidmore , Matthew Vick , "John Ronciak" , Mitch Williams , David Miller To: Arnd Bergmann Return-path: Received: from mga02.intel.com ([134.134.136.20]:10768 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752290AbbJMTZM (ORCPT ); Tue, 13 Oct 2015 15:25:12 -0400 In-Reply-To: <57023416.17EujnXPCo@wuerfel> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 13 Oct 2015 13:37:04 +0200 Arnd Bergmann wrote: > On Monday 12 October 2015 23:18:21 you wrote: > > On Wed, 2015-10-07 at 22:13 +0200, Arnd Bergmann wrote: > > > Jesse Brandeburg fixed a bug for 32-bit systems in the i40e driver > > > in commit 9c70d7cebfec5 ("i40e: fix 32 bit build warnings"), but the > > > same code still exists in the i40evf driver and causes compilation > > > warnings in ARM and x86 allmodconfig: > > > > > > drivers/net/ethernet/intel/i40evf/i40e_common.c:445:68: warning: cast > > > from pointer to integer of different size [-Wpointer-to-int-cast] > > > drivers/net/ethernet/intel/i40evf/i40e_common.c:446:71: warning: cast > > > from pointer to integer of different size [-Wpointer-to-int-cast] > > > > > > This applies the same fix by removing the broken code. > > > > > > Signed-off-by: Arnd Bergmann > > > > Does not apply at all to my next-queue tree (dev-queue branch), my > > guess is that this is already fixed in one of the patches already in my > > queue. > > > > I still get these warnings on your branch: Make sure you're pulling from the dev-queue branch, not the master branch of Jeff's next-queue repo. I've made that mistake many times, and I do see that the code in question is not present in: https://git.kernel.org/cgit/linux/kernel/git/jkirsher/next-queue.git/tree/drivers/net/ethernet/intel/i40evf/i40e_common.c?h=dev-queue