From: Richard Cochran <richardcochran@gmail.com>
To: Christopher Hall <christopher.s.hall@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
jeffrey.t.kirsher@intel.com, hpa@zytor.com, mingo@redhat.com,
john.stultz@linaro.org, peterz@infradead.org, x86@kernel.org,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kevin.b.stanton@intel.com
Subject: Re: [PATCH v4 1/4] Produce system time from correlated clocksource
Date: Thu, 15 Oct 2015 07:57:35 +0200 [thread overview]
Message-ID: <20151015055734.GB4784@netboy> (raw)
In-Reply-To: <op.x6iyd7gq1774gr@chall-mobl2.amr.corp.intel.com>
On Wed, Oct 14, 2015 at 06:57:33PM -0700, Christopher Hall wrote:
> >>+#define SHADOW_HISTORY_DEPTH 7
> >
> >And that number is 7 because?
>
> Due to power of 2 it will be 8 instead. As above the useful history is 8-2*1
> ms (1 ms is the minimum jiffy length). Array size 4 would not be enough
> history for the DSP which requires 4 ms of history, in the worst case.
Just as I suspected, the magic number 7 is based on the needs of one
particular user. What about the next user who comes along needing 10
milliseconds? That will not do. Any new interface should be generic
enough to support a wide range of users.
So I think this approach is all wrong. Here is an idea for you to
consider. Instead of mucking with the TK, let the user code (possibly
in-kernel) sample ART/sys pairs and interpolate the ART/dev time
stamps. That way, the user can choose the range and resolution that
he needs.
> The audio driver is structured in such a way that it's simpler to provide a
> value rather than a callback.
Can you please provide a link to the audio driver that uses this new
interface?
Thanks,
Richard
next prev parent reply other threads:[~2015-10-15 5:57 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 18:45 [PATCH v4 0/4] Patchset enabling hardware based cross-timestamps for next gen Intel platforms Christopher S. Hall
2015-10-12 18:45 ` [PATCH v4 1/4] Produce system time from correlated clocksource Christopher S. Hall
2015-10-13 4:58 ` Richard Cochran
2015-10-13 7:51 ` Thomas Gleixner
2015-10-13 8:31 ` Richard Cochran
2015-10-13 19:15 ` Thomas Gleixner
2015-10-13 21:12 ` Richard Cochran
2015-10-14 7:21 ` Thomas Gleixner
2015-10-14 9:29 ` Richard Cochran
2015-10-14 14:22 ` Thomas Gleixner
2015-10-14 16:18 ` Richard Cochran
2015-10-15 2:34 ` Christopher Hall
2015-10-15 5:41 ` Richard Cochran
2015-10-15 8:13 ` Thomas Gleixner
2015-10-13 5:26 ` Richard Cochran
2015-10-13 13:50 ` Richard Cochran
2015-10-13 19:42 ` Thomas Gleixner
2015-10-15 1:57 ` Christopher Hall
2015-10-15 5:57 ` Richard Cochran [this message]
2015-10-15 8:15 ` Thomas Gleixner
2015-10-20 0:18 ` Christopher Hall
2015-10-20 0:36 ` John Stultz
2015-10-20 8:54 ` Richard Cochran
2015-10-20 10:48 ` Thomas Gleixner
2015-10-20 11:51 ` Richard Cochran
2015-10-20 14:55 ` Richard Cochran
2015-10-20 19:11 ` Thomas Gleixner
2015-10-20 19:36 ` Richard Cochran
2015-10-20 20:16 ` John Stultz
2015-10-21 7:44 ` Thomas Gleixner
2015-11-03 19:18 ` Stanton, Kevin B
2015-11-09 21:17 ` John Stultz
2015-10-12 18:45 ` [PATCH v4 2/4] Always running timer " Christopher S. Hall
2015-10-13 2:03 ` kbuild test robot
2015-11-18 23:53 ` Jacob Pan
2015-10-12 18:45 ` [PATCH v4 3/4] Add PTP_SYS_OFFSET_PRECISE for driver crosstimestamping Christopher S. Hall
2015-10-13 13:59 ` Richard Cochran
2015-10-15 2:47 ` Christopher Hall
2015-11-07 2:15 ` Christopher Hall
2015-10-12 18:45 ` [PATCH v4 4/4] Adds hardware supported cross timestamp Christopher S. Hall
2015-10-13 2:10 ` kbuild test robot
2015-10-13 2:11 ` kbuild test robot
2015-10-13 2:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151015055734.GB4784@netboy \
--to=richardcochran@gmail.com \
--cc=christopher.s.hall@intel.com \
--cc=hpa@zytor.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=john.stultz@linaro.org \
--cc=kevin.b.stanton@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).