From: Thomas Graf <tgraf@suug.ch>
To: Jiri Benc <jbenc@redhat.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [RFC PATCH net-next 0/9] netlink: strict attribute checking option
Date: Fri, 16 Oct 2015 10:09:25 +0200 [thread overview]
Message-ID: <20151016080925.GA9714@pox.localdomain> (raw)
In-Reply-To: <20151016100221.6fd5034f@griffin>
On 10/16/15 at 10:02am, Jiri Benc wrote:
> On Fri, 16 Oct 2015 01:06:44 -0700 (PDT), David Miller wrote:
> > No, it's definitely not OK, because lwtunnel support exists in
> > Linus's tree.
> >
> > And tools should be able to work on all kernels where lwtunnel support
> > is available.
>
> You can consider the lwtunnels feature as not finished in the current
> Linus's tree. It works, it won't change (thus anything using it in its
> current form will continue to work in all the future kernels), but
> mainstream tools won't make use of it until a kernel version later
> which will get some additional support.
>
> I don't think it's much of a problem and I don't think it is the first
> time this would happen.
>
> I'm afraid I don't have any solution that could do better.
Maybe we should be more precise here. The detection mechanism is only
for tools which want to know whether lwt or another feature is supported
without going through the pain of creating an object, checking its
attributes and then deleting the object again if no full support was
detected. The existing flow of configuration through iproute2 will be
supported just like for any other new feature that we have introduced.
Therefore, I consider this a future optimization.
This is very much related to the offload problematic we had or still
have of "only program in HW if you can do the full thing vs best effort"
so this flag will be of use in a wider context.
next prev parent reply other threads:[~2015-10-16 8:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 16:39 [RFC PATCH net-next 0/9] netlink: strict attribute checking option Jiri Benc
2015-10-15 16:39 ` [RFC PATCH net-next 1/9] netlink: add NLM_F_STRICT for strict attribute checking Jiri Benc
2015-10-15 16:39 ` [RFC PATCH net-next 2/9] netlink: remove unnecesary goto's Jiri Benc
2015-10-15 16:39 ` [RFC PATCH net-next 3/9] netlink: strict attribute parsing Jiri Benc
2015-10-15 16:39 ` [RFC PATCH net-next 4/9] netlink: strict attribute validation Jiri Benc
2015-10-15 16:39 ` [RFC PATCH net-next 5/9] rtnetlink: support strict attribute checking Jiri Benc
2015-10-15 16:39 ` [RFC PATCH net-next 6/9] rtnetlink: add strict parameter to validate callbacks Jiri Benc
2015-10-15 16:39 ` [RFC PATCH net-next 7/9] rtnetlink: add strict parameter to validate_link_af Jiri Benc
2015-10-15 16:39 ` [RFC PATCH net-next 8/9] rtnetlink: support strict checking for newlink, setlink and dellink Jiri Benc
2015-10-15 16:39 ` [RFC PATCH net-next 9/9] veth: validate nested attributes Jiri Benc
2015-10-15 22:07 ` [RFC PATCH net-next 0/9] netlink: strict attribute checking option Hannes Frederic Sowa
2015-10-16 7:49 ` Jiri Benc
2015-10-16 8:08 ` David Miller
2015-10-16 8:08 ` Jiri Benc
2015-10-16 9:40 ` Hannes Frederic Sowa
2015-10-16 10:00 ` Jiri Benc
2015-10-16 6:50 ` David Miller
2015-10-16 7:39 ` Jiri Benc
2015-10-16 8:06 ` David Miller
2015-10-16 8:02 ` Jiri Benc
2015-10-16 8:09 ` Thomas Graf [this message]
2015-10-16 15:57 ` David Ahern
2015-10-19 2:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151016080925.GA9714@pox.localdomain \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=jbenc@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).