* [PATCH iproute2] ip monitor neigh: Change 'delete' to 'Deleted' to be consistent with ip route
@ 2015-10-15 18:47 Roopa Prabhu
2015-10-16 7:18 ` Nicolas Dichtel
2015-10-16 23:02 ` Stephen Hemminger
0 siblings, 2 replies; 3+ messages in thread
From: Roopa Prabhu @ 2015-10-15 18:47 UTC (permalink / raw)
To: stephen; +Cc: netdev, nicolas.dichtel
From: Roopa Prabhu <roopa@cumulusnetworks.com>
It helps to grep for one string "Deleted" when monitoring all events.
Fixes: 6ea3ebafe077 ("iproute2: inform user when a neighbor is removed")
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
---
I am not sure if it is too late for this change. But, sending this patch
out because it only affects ip monitor output
ip/ipneigh.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ip/ipneigh.c b/ip/ipneigh.c
index a9e23f4..ce57ede 100644
--- a/ip/ipneigh.c
+++ b/ip/ipneigh.c
@@ -256,7 +256,7 @@ int print_neigh(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg)
}
if (n->nlmsg_type == RTM_DELNEIGH)
- fprintf(fp, "delete ");
+ fprintf(fp, "Deleted ");
else if (n->nlmsg_type == RTM_GETNEIGH)
fprintf(fp, "miss ");
if (tb[NDA_DST]) {
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH iproute2] ip monitor neigh: Change 'delete' to 'Deleted' to be consistent with ip route
2015-10-15 18:47 [PATCH iproute2] ip monitor neigh: Change 'delete' to 'Deleted' to be consistent with ip route Roopa Prabhu
@ 2015-10-16 7:18 ` Nicolas Dichtel
2015-10-16 23:02 ` Stephen Hemminger
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Dichtel @ 2015-10-16 7:18 UTC (permalink / raw)
To: Roopa Prabhu, stephen; +Cc: netdev
Le 15/10/2015 20:47, Roopa Prabhu a écrit :
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> It helps to grep for one string "Deleted" when monitoring all events.
>
> Fixes: 6ea3ebafe077 ("iproute2: inform user when a neighbor is removed")
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> ---
> I am not sure if it is too late for this change. But, sending this patch
> out because it only affects ip monitor output
Seems reasonable to me, but I let Stephen speaking at this.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH iproute2] ip monitor neigh: Change 'delete' to 'Deleted' to be consistent with ip route
2015-10-15 18:47 [PATCH iproute2] ip monitor neigh: Change 'delete' to 'Deleted' to be consistent with ip route Roopa Prabhu
2015-10-16 7:18 ` Nicolas Dichtel
@ 2015-10-16 23:02 ` Stephen Hemminger
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2015-10-16 23:02 UTC (permalink / raw)
To: Roopa Prabhu; +Cc: netdev, nicolas.dichtel
On Thu, 15 Oct 2015 11:47:43 -0700
Roopa Prabhu <roopa@cumulusnetworks.com> wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> It helps to grep for one string "Deleted" when monitoring all events.
>
> Fixes: 6ea3ebafe077 ("iproute2: inform user when a neighbor is removed")
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
> ---
> I am not sure if it is too late for this change. But, sending this patch
> out because it only affects ip monitor output
>
Sure applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-16 23:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-15 18:47 [PATCH iproute2] ip monitor neigh: Change 'delete' to 'Deleted' to be consistent with ip route Roopa Prabhu
2015-10-16 7:18 ` Nicolas Dichtel
2015-10-16 23:02 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).