From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: SoCFPGA ethernet broken
Date: Fri, 16 Oct 2015 21:38:54 +0200
Message-ID: <20151016193854.GC28207@lunn.ch>
References: <56201158.8040806@opensource.altera.com>
 <56201AE7.2020103@gmail.com>
 <alpine.DEB.2.02.1510152102280.22844@linux-builds1>
 <20151016033143.GA28207@lunn.ch>
 <alpine.DEB.2.02.1510160935310.22648@linux-builds1>
 <20151016150345.GI10146@lunn.ch>
 <alpine.DEB.2.02.1510161027590.16637@linux-builds1>
 <20151016155644.GJ10146@lunn.ch>
 <56212A09.5080206@caviumnetworks.com>
 <alpine.DEB.2.02.1510161407570.22838@linux-builds1>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: David Daney <ddaney@caviumnetworks.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	"David S. Miller" <davem@davemloft.net>, david.daney@cavium.com,
	netdev@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
To: Dinh Nguyen <dinguyen@opensource.altera.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.02.1510161407570.22838@linux-builds1>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

> > Maybe we need to walk up the hierarchy.
> > 
> > Perhaps something like:
> > 
> > const struct device *dev_walker;
> > 
> > dev_walker = &phydev->dev;
> > do {
> >    of_node = dev_walker->of_node;
> >    dev_walker = dev_walker->parent;
> > } while (!of_node && dev_walker);
> > 
> 
> The above code seems to have fixed the issue.

What i don't like about this is that it allows you to put these
properties in the mdio device node. These are phy properties, not mdio
properties....

If phydev->attached_dev->dev->of_node works, that would be my
preference.

       Andrew