From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
linux-kernel@vger.kernel.org, ssantosh@kernel.org
Subject: Re: [PATCH net-next] RDS: fix rds-ping deadlock over TCP transport
Date: Fri, 16 Oct 2015 21:45:34 -0400 [thread overview]
Message-ID: <20151017014534.GH5464@oracle.com> (raw)
In-Reply-To: <1445041610-30133-1-git-send-email-santosh.shilimkar@oracle.com>
On (10/16/15 20:26), Santosh Shilimkar wrote:
>
> diff --git a/net/rds/send.c b/net/rds/send.c
> + if (!test_bit(RDS_LL_SEND_FULL, &conn->c_flags))
> + queue_delayed_work(rds_wq, &conn->c_send_w, 0);
A minor note- it would help to add some comments here explaining
that the pong has already been added to the sendq earlier..
in the case of IB, if RDS_LL_SEND_FULL has been set, it takes some
head-scratching to figure out how the pong gets sent, and a few
comments could help clarify that.
but other than that, the contents look good to me, thus
Acked-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
next prev parent reply other threads:[~2015-10-17 1:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-17 0:26 [PATCH net-next] RDS: fix rds-ping deadlock over TCP transport Santosh Shilimkar
2015-10-17 1:45 ` Sowmini Varadhan [this message]
2015-10-17 1:57 ` santosh shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151017014534.GH5464@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=santosh.shilimkar@oracle.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).