From: Thomas Graf <tgraf@suug.ch>
To: Joe Stringer <joestringer@nicira.com>
Cc: netdev@vger.kernel.org, pshelar@nicira.com
Subject: Re: [PATCHv2 net 3/3] openvswitch: Serialize nested ct actions if provided
Date: Sat, 17 Oct 2015 09:54:17 +0200 [thread overview]
Message-ID: <20151017075417.GD13981@pox.localdomain> (raw)
In-Reply-To: <1445018901-18839-4-git-send-email-joestringer@nicira.com>
On 10/16/15 at 11:08am, Joe Stringer wrote:
> If userspace provides a ct action with no nested mark or label, then the
> storage for these fields is zeroed. Later when actions are requested,
> such zeroed fields are serialized even though userspace didn't
> originally specify them. Fix the behaviour by ensuring that no action is
> serialized in this case, and reject actions where userspace attempts to
> set these fields with mask=0. This should make netlink marshalling
> consistent across deserialization/reserialization.
>
> Reported-by: Jarno Rajahalme <jrajahalme@nicira.com>
> Signed-off-by: Joe Stringer <joestringer@nicira.com>
Acked-by: Thomas Graf <tgraf@suug.ch>
next prev parent reply other threads:[~2015-10-17 7:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 18:08 [PATCHv2 net] openvswitch: Scrub skb between namespaces Joe Stringer
2015-10-16 18:08 ` [PATCHv2 net 1/3] openvswitch: Reject ct_state masks for unknown bits Joe Stringer
2015-10-17 7:46 ` Thomas Graf
2015-10-16 18:08 ` [PATCHv2 net 2/3] openvswitch: Treat IP_CT_RELATED as new Joe Stringer
2015-10-17 7:52 ` Thomas Graf
2015-10-19 7:07 ` Joe Stringer
2015-10-19 9:03 ` Thomas Graf
2015-10-19 23:13 ` Joe Stringer
2015-10-20 0:25 ` Thomas Graf
2015-10-16 18:08 ` [PATCHv2 net 3/3] openvswitch: Serialize nested ct actions if provided Joe Stringer
2015-10-16 19:03 ` Pravin Shelar
2015-10-17 7:54 ` Thomas Graf [this message]
2015-10-16 18:47 ` [PATCHv2 net] openvswitch: Scrub skb between namespaces Pravin Shelar
2015-10-17 7:55 ` Thomas Graf
2015-10-19 5:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151017075417.GD13981@pox.localdomain \
--to=tgraf@suug.ch \
--cc=joestringer@nicira.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox