From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Jiri Benc <jbenc@redhat.com>
Cc: netdev@vger.kernel.org, Thomas Haller <thaller@redhat.com>
Subject: Re: [PATCH net] net: try harder to not reuse ifindex when moving interfaces
Date: Mon, 19 Oct 2015 08:36:10 -0700 [thread overview]
Message-ID: <20151019153609.GA19724@Alexeis-MBP.westell.com> (raw)
In-Reply-To: <20151019110649.726f1fe0@griffin>
On Mon, Oct 19, 2015 at 11:06:49AM +0200, Jiri Benc wrote:
> On Sun, 18 Oct 2015 08:11:58 -0700, Alexei Starovoitov wrote:
> > it looks dangerous.
> > Does it mean that 'for (4B) { create new dev; free old dev; }
> > will keep incrementing that max index and dos it eventually?
>
> This is not changed by this patch in any way. As for the current
> behavior (with or without my patch), by creating and deleting an
> interface, the max index indeed keeps incrementing. There's no DoS,
> however, as the index simply wraps to 1 when reaching maxint. See
> dev_new_index(). This is something I count on in this patch.
makes sense. thanks for explaining.
next prev parent reply other threads:[~2015-10-19 15:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 11:07 [PATCH net] net: try harder to not reuse ifindex when moving interfaces Jiri Benc
2015-10-18 15:11 ` Alexei Starovoitov
2015-10-19 9:06 ` Jiri Benc
2015-10-19 15:36 ` Alexei Starovoitov [this message]
2015-10-21 14:43 ` David Miller
2015-10-21 14:46 ` Jiri Benc
2015-10-21 15:32 ` David Miller
2015-10-21 15:25 ` Jiri Benc
2015-10-21 15:56 ` David Miller
2015-10-21 17:12 ` Hannes Frederic Sowa
2015-10-22 14:52 ` Nicolas Dichtel
2015-10-22 15:00 ` Jiri Benc
2015-10-22 15:10 ` Hannes Frederic Sowa
2015-10-22 15:20 ` Thomas Haller
2015-10-22 15:23 ` Nicolas Dichtel
2015-10-22 16:45 ` Thomas Graf
2015-10-22 17:21 ` Hannes Frederic Sowa
2015-10-22 18:56 ` Thomas Graf
2015-10-23 10:40 ` Thomas Haller
2015-10-22 15:21 ` Thomas Haller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151019153609.GA19724@Alexeis-MBP.westell.com \
--to=alexei.starovoitov@gmail.com \
--cc=jbenc@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=thaller@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).