From: "Michael Büsch" <m@bues.ch>
To: Paul McQuade <paulmcquad@gmail.com>, kvalo@codeaurora.org
Cc: zajec5@gmail.com, davem@davemloft.net, joe@perches.com,
johannes.berg@intel.com, sd@queasysnail.net,
mike.looijmans@topic.nl, khoroshilov@ispras.ru, cengelma@gmx.at,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] net: wireless: b43: Coding Style
Date: Mon, 19 Oct 2015 18:07:42 +0200 [thread overview]
Message-ID: <20151019180742.2d6bf8f1@wiggum> (raw)
In-Reply-To: <1445270543-2209-3-git-send-email-paulmcquad@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3090 bytes --]
On Mon, 19 Oct 2015 17:02:22 +0100
Paul McQuade <paulmcquad@gmail.com> wrote:
> Fixed Pointer Coding Style
>
> Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
> ---
> drivers/net/wireless/b43/main.c | 6 +++---
> drivers/net/wireless/b43/main.h | 2 +-
> drivers/net/wireless/b43/xmit.h | 2 +-
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
> index 2849070..040caa4 100644
> --- a/drivers/net/wireless/b43/main.c
> +++ b/drivers/net/wireless/b43/main.c
> @@ -364,7 +364,7 @@ static struct ieee80211_supported_band b43_band_2ghz_limited = {
>
> static void b43_wireless_core_exit(struct b43_wldev *dev);
> static int b43_wireless_core_init(struct b43_wldev *dev);
> -static struct b43_wldev * b43_wireless_core_stop(struct b43_wldev *dev);
> +static struct b43_wldev *b43_wireless_core_stop(struct b43_wldev *dev);
> static int b43_wireless_core_start(struct b43_wldev *dev);
> static void b43_op_bss_info_changed(struct ieee80211_hw *hw,
> struct ieee80211_vif *vif,
> @@ -989,7 +989,7 @@ static void do_key_write(struct b43_wldev *dev,
> * 0xffffffff and let's b43_op_update_tkip_key provide a
> * correct pair.
> */
> - rx_tkip_phase1_write(dev, index, 0xffffffff, (u16*)buf);
> + rx_tkip_phase1_write(dev, index, 0xffffffff, (u16 *)buf);
> } else if (index >= pairwise_keys_start) /* clear it */
> rx_tkip_phase1_write(dev, index, 0, NULL);
> if (key)
> @@ -4334,7 +4334,7 @@ out_unlock:
> /* Locking: wl->mutex
> * Returns the current dev. This might be different from the passed in dev,
> * because the core might be gone away while we unlocked the mutex. */
> -static struct b43_wldev * b43_wireless_core_stop(struct b43_wldev *dev)
> +static struct b43_wldev *b43_wireless_core_stop(struct b43_wldev *dev)
> {
> struct b43_wl *wl;
> struct b43_wldev *orig_dev;
> diff --git a/drivers/net/wireless/b43/main.h b/drivers/net/wireless/b43/main.h
> index c46430c..fa56b22 100644
> --- a/drivers/net/wireless/b43/main.h
> +++ b/drivers/net/wireless/b43/main.h
> @@ -73,7 +73,7 @@ static inline int b43_is_ofdm_rate(int rate)
> u8 b43_ieee80211_antenna_sanitize(struct b43_wldev *dev,
> u8 antenna_nr);
>
> -void b43_tsf_read(struct b43_wldev *dev, u64 * tsf);
> +void b43_tsf_read(struct b43_wldev *dev, u64 *tsf);
> void b43_tsf_write(struct b43_wldev *dev, u64 tsf);
>
> u32 b43_shm_read32(struct b43_wldev *dev, u16 routing, u16 offset);
> diff --git a/drivers/net/wireless/b43/xmit.h b/drivers/net/wireless/b43/xmit.h
> index ba61153..fed8657 100644
> --- a/drivers/net/wireless/b43/xmit.h
> +++ b/drivers/net/wireless/b43/xmit.h
> @@ -203,7 +203,7 @@ size_t b43_txhdr_size(struct b43_wldev *dev)
>
>
> int b43_generate_txhdr(struct b43_wldev *dev,
> - u8 * txhdr,
> + u8 *txhdr,
> struct sk_buff *skb_frag,
> struct ieee80211_tx_info *txctl, u16 cookie);
>
Acked-by: Michael Buesch <m@bues.ch>
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-10-19 16:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 16:02 [PATCH v2 0/3] Coding Style Cleanning Paul McQuade
2015-10-19 16:02 ` [PATCH v2 1/3] net: wireless: rsi: Coding Spaces Paul McQuade
2015-10-19 16:02 ` [PATCH v2 2/3] net: wireless: b43: Coding Style Paul McQuade
2015-10-19 16:07 ` Michael Büsch [this message]
2016-02-02 16:25 ` [v2,2/3] " Sudip Mukherjee
2015-10-19 16:02 ` [PATCH v2 3/3] net: wireless: b43: Statics are init to 0 Paul McQuade
2015-10-19 16:11 ` Michael Büsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151019180742.2d6bf8f1@wiggum \
--to=m@bues.ch \
--cc=b43-dev@lists.infradead.org \
--cc=cengelma@gmx.at \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=johannes.berg@intel.com \
--cc=khoroshilov@ispras.ru \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mike.looijmans@topic.nl \
--cc=netdev@vger.kernel.org \
--cc=paulmcquad@gmail.com \
--cc=sd@queasysnail.net \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).