From: "Michael Büsch" <m@bues.ch>
To: "Paul McQuade" <paulmcquad@gmail.com>,
"Gábor Stefanik" <netrolller.3d@gmail.com>
Cc: kvalo@codeaurora.org, zajec5@gmail.com, davem@davemloft.net,
joe@perches.com, johannes.berg@intel.com, sd@queasysnail.net,
mike.looijmans@topic.nl, khoroshilov@ispras.ru, cengelma@gmx.at,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] net: wireless: b43: Statics are init to 0
Date: Mon, 19 Oct 2015 18:11:57 +0200 [thread overview]
Message-ID: <20151019181157.7018b25c@wiggum> (raw)
In-Reply-To: <1445270543-2209-4-git-send-email-paulmcquad@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 849 bytes --]
On Mon, 19 Oct 2015 17:02:23 +0100
Paul McQuade <paulmcquad@gmail.com> wrote:
> diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c
> index 058a9f2..086f0ba 100644
> --- a/drivers/net/wireless/b43/phy_lp.c
> +++ b/drivers/net/wireless/b43/phy_lp.c
> @@ -2502,7 +2502,7 @@ static int lpphy_b2063_tune(struct b43_wldev *dev,
> {
> struct ssb_bus *bus = dev->dev->sdev->bus;
>
> - static const struct b206x_channel *chandata = NULL;
> + static const struct b206x_channel *chandata;
> u32 crystal_freq = bus->chipco.pmu.crystalfreq * 1000;
> u32 freqref, vco_freq, val1, val2, val3, timeout, timeoutref, count;
> u16 old_comm15, scale;
Why on earth is this static anyway? That seems really wrong here.
The static should be removed (and the =NULL init be left in place.)
--
Michael
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-10-19 16:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 16:02 [PATCH v2 0/3] Coding Style Cleanning Paul McQuade
2015-10-19 16:02 ` [PATCH v2 1/3] net: wireless: rsi: Coding Spaces Paul McQuade
2015-10-19 16:02 ` [PATCH v2 2/3] net: wireless: b43: Coding Style Paul McQuade
2015-10-19 16:07 ` Michael Büsch
2016-02-02 16:25 ` [v2,2/3] " Sudip Mukherjee
2015-10-19 16:02 ` [PATCH v2 3/3] net: wireless: b43: Statics are init to 0 Paul McQuade
2015-10-19 16:11 ` Michael Büsch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151019181157.7018b25c@wiggum \
--to=m@bues.ch \
--cc=b43-dev@lists.infradead.org \
--cc=cengelma@gmx.at \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=johannes.berg@intel.com \
--cc=khoroshilov@ispras.ru \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mike.looijmans@topic.nl \
--cc=netdev@vger.kernel.org \
--cc=netrolller.3d@gmail.com \
--cc=paulmcquad@gmail.com \
--cc=sd@queasysnail.net \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).