From: Thomas Graf <tgraf@suug.ch>
To: Richard Laing <Richard.Laing@alliedtelesis.co.nz>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: Routing Policy Database Rule 0
Date: Tue, 20 Oct 2015 10:45:48 +0200 [thread overview]
Message-ID: <20151020084548.GC25435@pox.localdomain> (raw)
In-Reply-To: <56259FB9.8020706@alliedtelesis.co.nz>
On 10/20/15 at 01:58am, Richard Laing wrote:
> Hi,
>
> We recently found a bug in our code which resulted in rule 0 in the
> routing policy database being deleted, this is a bad thing and the man
> page documentation for "ip rule" indicates
>
> Rule 0 is special. It cannot be deleted or overridden.
>
> which seems entirely reasonable. The code in net/core/fib_rules.c does
> not seem to protect against deletion of this rule and I was wondering if
> there is a reason for this. If not I will submit a patch to address it.
This behaviour was changed in commit 5adef1809
("net: fib_rules: allow to delete local rule") so it seems the manual
page is outdated. Feel free to send a patch.
> Simply running "ip rule del" shows the issue .
This however looks like a bug.
prev parent reply other threads:[~2015-10-20 8:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 1:58 Routing Policy Database Rule 0 Richard Laing
2015-10-20 8:45 ` Thomas Graf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151020084548.GC25435@pox.localdomain \
--to=tgraf@suug.ch \
--cc=Richard.Laing@alliedtelesis.co.nz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox