* Routing Policy Database Rule 0
@ 2015-10-20 1:58 Richard Laing
2015-10-20 8:45 ` Thomas Graf
0 siblings, 1 reply; 2+ messages in thread
From: Richard Laing @ 2015-10-20 1:58 UTC (permalink / raw)
To: netdev@vger.kernel.org
Hi,
We recently found a bug in our code which resulted in rule 0 in the
routing policy database being deleted, this is a bad thing and the man
page documentation for "ip rule" indicates
Rule 0 is special. It cannot be deleted or overridden.
which seems entirely reasonable. The code in net/core/fib_rules.c does
not seem to protect against deletion of this rule and I was wondering if
there is a reason for this. If not I will submit a patch to address it.
Simply running "ip rule del" shows the issue .
Regards,
Richard Laing
--
*Richard Laing*
Software Team Leader*
Allied Telesis Labs*| 27 Nazareth Ave | Christchurch 8024 | New Zealand
Phone: +64 3 3393000 | DDI: +64 3 339 9248 | Web: *alliedtelesis.com
<http://alliedtelesis.com/>*<skype:andrewriddell3?chat>
http://productselector.alliedtelesis.eu/
<http://productselector.alliedtelesis.eu/>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Routing Policy Database Rule 0
2015-10-20 1:58 Routing Policy Database Rule 0 Richard Laing
@ 2015-10-20 8:45 ` Thomas Graf
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Graf @ 2015-10-20 8:45 UTC (permalink / raw)
To: Richard Laing; +Cc: netdev@vger.kernel.org
On 10/20/15 at 01:58am, Richard Laing wrote:
> Hi,
>
> We recently found a bug in our code which resulted in rule 0 in the
> routing policy database being deleted, this is a bad thing and the man
> page documentation for "ip rule" indicates
>
> Rule 0 is special. It cannot be deleted or overridden.
>
> which seems entirely reasonable. The code in net/core/fib_rules.c does
> not seem to protect against deletion of this rule and I was wondering if
> there is a reason for this. If not I will submit a patch to address it.
This behaviour was changed in commit 5adef1809
("net: fib_rules: allow to delete local rule") so it seems the manual
page is outdated. Feel free to send a patch.
> Simply running "ip rule del" shows the issue .
This however looks like a bug.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-20 8:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-20 1:58 Routing Policy Database Rule 0 Richard Laing
2015-10-20 8:45 ` Thomas Graf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).