From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH resend] net: sun4i-emac: Properly free resources on probe failure and remove Date: Wed, 21 Oct 2015 19:48:26 -0700 (PDT) Message-ID: <20151021.194826.782971305803462043.davem@davemloft.net> References: <1445330544-6968-1-git-send-email-hdegoede@redhat.com> <1445330544-6968-2-git-send-email-hdegoede@redhat.com> Reply-To: davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To: hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org Return-path: In-Reply-To: <1445330544-6968-2-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , List-Id: netdev.vger.kernel.org From: Hans de Goede Date: Tue, 20 Oct 2015 10:42:24 +0200 > Fix sun4i-emac not releasing the following resources: > -iomapped memory not released on probe-failure nor on remove > -clock not getting disabled on probe-failure nor on remove > -sram not being released on remove > > And while at it also add error checking to the clk_prepare_enable call > done on probe. > > Signed-off-by: Hans de Goede Applied.