From: Stephen Hemminger <stephen@networkplumber.org>
To: netdev@vger.kernel.org
Subject: Fw: [Bug 106351] New: error in upstream commit 41fc014332d91ee90c32840bf161f9685b7fbf2b fib_rules:...
Date: Wed, 21 Oct 2015 09:02:46 -0700 [thread overview]
Message-ID: <20151021090246.11afdf26@xeon-e3> (raw)
Begin forwarded message:
Date: Tue, 20 Oct 2015 12:20:39 +0000
From: "bugzilla-daemon@bugzilla.kernel.org" <bugzilla-daemon@bugzilla.kernel.org>
To: "shemminger@linux-foundation.org" <shemminger@linux-foundation.org>
Subject: [Bug 106351] New: error in upstream commit 41fc014332d91ee90c32840bf161f9685b7fbf2b fib_rules:...
https://bugzilla.kernel.org/show_bug.cgi?id=106351
Bug ID: 106351
Summary: error in upstream commit
41fc014332d91ee90c32840bf161f9685b7fbf2b fib_rules:...
Product: Networking
Version: 2.5
Kernel Version: 3.14
Hardware: All
OS: Linux
Tree: Mainline
Status: NEW
Severity: normal
Priority: P1
Component: Other
Assignee: shemminger@linux-foundation.org
Reporter: m.koenigshaus@wut.de
Regression: No
Hi,
upstream commit 41fc014332d91ee90c32840bf161f9685b7fbf2b has a small flaw.
Before the patch, the loop in dump_rules (line 627 - 638, fib_rules.c) was
canceled if fib_nl_fill_rule returns a value less than zero, after the patch it
is canceled if fib_nl_fill_rule returns a nonzero value. But without errors
fib_nl_fill_rule will return skb-> len. So I thing the termination condition
should be "if (err < 0) break;" not "if (err) break;".
This error leads to OOM - Exceptions in our system with program "ip"! After
changing the code to "if (err < 0) break;" everything works fine.
Regards, Markus
--
You are receiving this mail because:
You are the assignee for the bug.
reply other threads:[~2015-10-21 16:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151021090246.11afdf26@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).