From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Steffen Klassert <steffen.klassert@secunet.com>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, herbert@gondor.apana.org.au,
dhowells@redhat.com, davem@davemloft.net,
zohar@linux.vnet.ibm.com, David.Woodhouse@intel.com
Subject: Re: [PATCH net-next 2/2] xfrm: Fix unaligned access in xfrm_notify_sa() for DELSA
Date: Wed, 21 Oct 2015 06:54:42 -0400 [thread overview]
Message-ID: <20151021105442.GM6948@oracle.com> (raw)
In-Reply-To: <20151021065704.GM7701@secunet.com>
On (10/21/15 08:57), Steffen Klassert wrote:
> > --- a/net/xfrm/xfrm_user.c
> > +++ b/net/xfrm/xfrm_user.c
> > @@ -2659,7 +2659,7 @@ static int xfrm_notify_sa(struct xfrm_state *x, const struct km_event *c)
> > if (attr == NULL)
> > goto out_free_skb;
> >
> > - p = nla_data(attr);
> > + p = PTR_ALIGN(nla_data(attr), __alignof__(*p));
>
> Hm, this breaks userspace notifications on 64-bit systems.
> Userspace expects this to be aligned to 4, with your patch
> it is aligned to 8 on 64-bit.
>
> Without your patch I get the correct notification when deleting a SA:
>
But __alignof__(*p) is 8 on sparc, and without the patch I get
all types of unaligned access. So what do you suggest as the fix?
(and openswan/pluto dont flag any errors with the patch, which is
a separate bug).
--Sowmini
next prev parent reply other threads:[~2015-10-21 10:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 21:23 [PATCH 0/2] xfrm/crypto: unaligned access fixes Sowmini Varadhan
2015-10-19 21:23 ` [PATCH 1/2] crypto/x509: Fix unaligned access in x509_get_sig_params() Sowmini Varadhan
2015-10-20 9:50 ` David Howells
2015-10-20 14:26 ` Herbert Xu
2015-10-19 21:23 ` [PATCH net-next 2/2] xfrm: Fix unaligned access in xfrm_notify_sa() for DELSA Sowmini Varadhan
2015-10-21 6:57 ` Steffen Klassert
2015-10-21 10:54 ` Sowmini Varadhan [this message]
2015-10-21 12:36 ` Sowmini Varadhan
2015-10-21 13:22 ` David Miller
2015-10-21 13:11 ` Sowmini Varadhan
2015-10-21 13:17 ` David Miller
2015-10-21 13:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151021105442.GM6948@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=David.Woodhouse@intel.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).