* [PATCH net-next] openvswitch: Fix incorrect type use.
@ 2015-10-21 3:47 Pravin B Shelar
2015-10-21 8:21 ` Thomas Graf
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Pravin B Shelar @ 2015-10-21 3:47 UTC (permalink / raw)
To: netdev; +Cc: Pravin B Shelar
Patch fixes following sparse warning.
net/openvswitch/flow_netlink.c:583:30: warning: incorrect type in assignment (different base types)
net/openvswitch/flow_netlink.c:583:30: expected restricted __be16 [usertype] ipv4
net/openvswitch/flow_netlink.c:583:30: got int
Fixes: 6b26ba3a7d ("openvswitch: netlink attributes for IPv6 tunneling")
Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
---
net/openvswitch/flow_netlink.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c
index 6799c8d..80e1f09 100644
--- a/net/openvswitch/flow_netlink.c
+++ b/net/openvswitch/flow_netlink.c
@@ -548,11 +548,11 @@ static int ip_tun_from_nlattr(const struct nlattr *attr,
struct sw_flow_match *match, bool is_mask,
bool log)
{
+ bool ttl = false, ipv4 = false, ipv6 = false;
+ __be16 tun_flags = 0;
+ int opts_type = 0;
struct nlattr *a;
int rem;
- bool ttl = false;
- __be16 tun_flags = 0, ipv4 = false, ipv6 = false;
- int opts_type = 0;
nla_for_each_nested(a, attr, rem) {
int type = nla_type(a);
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] openvswitch: Fix incorrect type use.
2015-10-21 3:47 [PATCH net-next] openvswitch: Fix incorrect type use Pravin B Shelar
@ 2015-10-21 8:21 ` Thomas Graf
2015-10-21 11:30 ` Jiri Benc
2015-10-22 13:46 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Graf @ 2015-10-21 8:21 UTC (permalink / raw)
To: Pravin B Shelar; +Cc: netdev
On 10/20/15 at 08:47pm, Pravin B Shelar wrote:
> Patch fixes following sparse warning.
> net/openvswitch/flow_netlink.c:583:30: warning: incorrect type in assignment (different base types)
> net/openvswitch/flow_netlink.c:583:30: expected restricted __be16 [usertype] ipv4
> net/openvswitch/flow_netlink.c:583:30: got int
>
> Fixes: 6b26ba3a7d ("openvswitch: netlink attributes for IPv6 tunneling")
> Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
Acked-by: Thomas Graf <tgraf@suug.ch>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] openvswitch: Fix incorrect type use.
2015-10-21 3:47 [PATCH net-next] openvswitch: Fix incorrect type use Pravin B Shelar
2015-10-21 8:21 ` Thomas Graf
@ 2015-10-21 11:30 ` Jiri Benc
2015-10-22 13:46 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Jiri Benc @ 2015-10-21 11:30 UTC (permalink / raw)
To: Pravin B Shelar; +Cc: netdev
On Tue, 20 Oct 2015 20:47:46 -0700, Pravin B Shelar wrote:
> --- a/net/openvswitch/flow_netlink.c
> +++ b/net/openvswitch/flow_netlink.c
> @@ -548,11 +548,11 @@ static int ip_tun_from_nlattr(const struct nlattr *attr,
> struct sw_flow_match *match, bool is_mask,
> bool log)
> {
> + bool ttl = false, ipv4 = false, ipv6 = false;
> + __be16 tun_flags = 0;
> + int opts_type = 0;
> struct nlattr *a;
> int rem;
> - bool ttl = false;
> - __be16 tun_flags = 0, ipv4 = false, ipv6 = false;
> - int opts_type = 0;
Seems that I appended the variables to a wrong line during one of the
rebases. Thanks for fixing this.
Acked-by: Jiri Benc <jbenc@redhat.com>
--
Jiri Benc
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] openvswitch: Fix incorrect type use.
2015-10-21 3:47 [PATCH net-next] openvswitch: Fix incorrect type use Pravin B Shelar
2015-10-21 8:21 ` Thomas Graf
2015-10-21 11:30 ` Jiri Benc
@ 2015-10-22 13:46 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2015-10-22 13:46 UTC (permalink / raw)
To: pshelar; +Cc: netdev
From: Pravin B Shelar <pshelar@nicira.com>
Date: Tue, 20 Oct 2015 20:47:46 -0700
> Patch fixes following sparse warning.
> net/openvswitch/flow_netlink.c:583:30: warning: incorrect type in assignment (different base types)
> net/openvswitch/flow_netlink.c:583:30: expected restricted __be16 [usertype] ipv4
> net/openvswitch/flow_netlink.c:583:30: got int
>
> Fixes: 6b26ba3a7d ("openvswitch: netlink attributes for IPv6 tunneling")
> Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-22 13:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-21 3:47 [PATCH net-next] openvswitch: Fix incorrect type use Pravin B Shelar
2015-10-21 8:21 ` Thomas Graf
2015-10-21 11:30 ` Jiri Benc
2015-10-22 13:46 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).