From: Stephen Hemminger <stephen@networkplumber.org>
To: Michael Chan <mchan@broadcom.com>
Cc: <davem@davemloft.net>, <prashant@broadcom.com>,
<eddie.wai@broadcom.com>, <huangjw@broadcom.com>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v4] bnxt_en: New Broadcom ethernet driver.
Date: Wed, 21 Oct 2015 17:31:53 -0700 [thread overview]
Message-ID: <20151021173153.0aac826e@xeon-e3> (raw)
In-Reply-To: <1445413508-14932-1-git-send-email-mchan@broadcom.com>
On Wed, 21 Oct 2015 03:45:08 -0400
Michael Chan <mchan@broadcom.com> wrote:
> +static inline void bnxt_enable_poll(struct bnxt_napi *bnapi)
> +{
> +#ifdef CONFIG_NET_RX_BUSY_POLL
> + atomic_set(&bnapi->poll_state, BNXT_STATE_IDLE);
> +#endif
> +}
We need a better way to abstract this and get the #ifdef
clutter out of the network drivers.
next prev parent reply other threads:[~2015-10-22 0:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 7:45 [PATCH net-next v4] bnxt_en: New Broadcom ethernet driver Michael Chan
2015-10-22 0:31 ` Stephen Hemminger [this message]
2015-10-22 14:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151021173153.0aac826e@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=eddie.wai@broadcom.com \
--cc=huangjw@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=prashant@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).