From: Peter Zijlstra <peterz@infradead.org>
To: "Wangnan (F)" <wangnan0@huawei.com>
Cc: Alexei Starovoitov <ast@plumgrid.com>,
"David S. Miller" <davem@davemloft.net>,
Ingo Molnar <mingo@kernel.org>, He Kuang <hekuang@huawei.com>,
Kaixu Xia <xiakaixu@huawei.com>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net-next] bpf: fix bpf_perf_event_read() helper
Date: Thu, 22 Oct 2015 14:41:42 +0200 [thread overview]
Message-ID: <20151022124142.GQ17308@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <5628D6EC.3040606@huawei.com>
On Thu, Oct 22, 2015 at 08:30:36PM +0800, Wangnan (F) wrote:
> I have a question on inherit, not related to this patch:
> Is it safe for perf to disable attr->inherit if the event is system wide?
> I haven't read relate code completely. In my current knowledge the behavior
> of a system wide perf event should be same whether inherit is set or not.
> Is that true?
Yes, .inherit is pointless for cpu wide events, if we allow creating cpu
events with .inherit set that's unfortunate.
next prev parent reply other threads:[~2015-10-22 12:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 22:58 [PATCH v2 net-next] bpf: fix bpf_perf_event_read() helper Alexei Starovoitov
2015-10-22 4:49 ` Wangnan (F)
2015-10-22 5:00 ` Alexei Starovoitov
2015-10-22 5:30 ` Wangnan (F)
2015-10-22 5:31 ` Wangnan (F)
2015-10-22 6:21 ` Alexei Starovoitov
2015-10-22 7:39 ` Wangnan (F)
2015-10-22 15:51 ` Alexei Starovoitov
2015-10-22 12:30 ` Wangnan (F)
2015-10-22 12:41 ` Peter Zijlstra [this message]
2015-10-22 13:57 ` Peter Zijlstra
2015-10-22 15:53 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151022124142.GQ17308@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ast@plumgrid.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hekuang@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wangnan0@huawei.com \
--cc=xiakaixu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).