From: David Miller <davem@davemloft.net>
To: g.nault@alphalink.fr
Cc: netdev@vger.kernel.org, paulus@samba.org,
nuclearcat@nuclearcat.com, Matt.Bennett@alliedtelesis.co.nz
Subject: Re: [PATCH net] ppp: fix pppoe_dev deletion condition in pppoe_release()
Date: Fri, 23 Oct 2015 03:30:48 -0700 (PDT) [thread overview]
Message-ID: <20151023.033048.1984003889137051787.davem@davemloft.net> (raw)
In-Reply-To: <6a9ae28f4128939528dcf64795f1de88b39a6118.1445525554.git.g.nault@alphalink.fr>
From: Guillaume Nault <g.nault@alphalink.fr>
Date: Thu, 22 Oct 2015 16:57:10 +0200
> We can't rely on PPPOX_ZOMBIE to decide whether to clear po->pppoe_dev.
> PPPOX_ZOMBIE can be set by pppoe_disc_rcv() even when po->pppoe_dev is
> NULL. So we have no guarantee that (sk->sk_state & PPPOX_ZOMBIE) implies
> (po->pppoe_dev != NULL).
> Since we're releasing a PPPoE socket, we want to release the pppoe_dev
> if it exists and reset sk_state to PPPOX_DEAD, no matter the previous
> value of sk_state. So we can just check for po->pppoe_dev and avoid any
> assumption on sk->sk_state.
>
> Fixes: 2b018d57ff18 ("pppoe: drop PPPOX_ZOMBIEs in pppoe_release")
> Signed-off-by: Guillaume Nault <g.nault@alphalink.fr>
Applied and queued up for -stable, thanks.
next prev parent reply other threads:[~2015-10-23 10:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 14:57 [PATCH net] ppp: fix pppoe_dev deletion condition in pppoe_release() Guillaume Nault
2015-10-23 10:30 ` David Miller [this message]
2015-11-20 18:58 ` Christoph Schulz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151023.033048.1984003889137051787.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Matt.Bennett@alliedtelesis.co.nz \
--cc=g.nault@alphalink.fr \
--cc=netdev@vger.kernel.org \
--cc=nuclearcat@nuclearcat.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox