From: Stephen Hemminger <shemming@brocade.com>
To: Phil Sutter <phil@nwl.cc>
Cc: <netdev@vger.kernel.org>, Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Subject: Re: [iproute RFC PATCH 0/9] Document tc filters
Date: Fri, 23 Oct 2015 15:41:12 -0700 [thread overview]
Message-ID: <20151023154112.7e57c730@xeon-e3> (raw)
In-Reply-To: <1445622436-6386-1-git-send-email-phil@nwl.cc>
On Fri, 23 Oct 2015 19:47:07 +0200
Phil Sutter <phil@nwl.cc> wrote:
> This series adds documentation in form of a dedicated man page for every
> available tc filter with the exception of rsvp which I simply didn't
> understand. In addition to that, it adds a list of filters with (very) basic
> description to tc.8, listing the specific man pages for detailed information.
>
> I am not too confident of correctness in every aspect, therefore this series is
> tagged RFC and the relevant patches are Cc'ed to the filter authors in hope for
> review and harsh criticism in form of corrections. :)
>
> Alexey or anyone else with knowledge of rsvp, you could make me very happy by
> explaining to me how that filter is supposed to work. In turn I could serve you
> with stupid^Wunqualified questions and ultimately tc-rsvp.8 which you would
> then have to proof-read as well.
>
> Phil Sutter (9):
> tc: add a man page for basic filter
> tc: add a man page for cgroup filter
> tc: add a man page for flow filter
> tc: add a man page for flower filter
> tc: add a man page for fw filter
> tc: add a man page for route filter
> tc: add a man page for tcindex filter
> tc: add a man page for u32 filter
> tc: ship filter man pages and refer to them in tc.8
>
> man/man8/Makefile | 4 +-
> man/man8/tc-basic.8 | 34 +++
> man/man8/tc-cgroup.8 | 80 ++++++
> man/man8/tc-flow.8 | 265 ++++++++++++++++++++
> man/man8/tc-flower.8 | 113 +++++++++
> man/man8/tc-fw.8 | 66 +++++
> man/man8/tc-route.8 | 74 ++++++
> man/man8/tc-tcindex.8 | 58 +++++
> man/man8/tc-u32.8 | 663 ++++++++++++++++++++++++++++++++++++++++++++++++++
> man/man8/tc.8 | 52 ++++
> 10 files changed, 1408 insertions(+), 1 deletion(-)
> create mode 100644 man/man8/tc-basic.8
> create mode 100644 man/man8/tc-cgroup.8
> create mode 100644 man/man8/tc-flow.8
> create mode 100644 man/man8/tc-flower.8
> create mode 100644 man/man8/tc-fw.8
> create mode 100644 man/man8/tc-route.8
> create mode 100644 man/man8/tc-tcindex.8
> create mode 100644 man/man8/tc-u32.8
>
Looks good applied.
Had to one minor whitespace cleanup.
prev parent reply other threads:[~2015-10-23 22:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 17:47 [iproute RFC PATCH 0/9] Document tc filters Phil Sutter
2015-10-23 17:47 ` [iproute RFC PATCH 1/9] tc: add a man page for basic filter Phil Sutter
2015-10-23 17:47 ` [iproute RFC PATCH 2/9] tc: add a man page for cgroup filter Phil Sutter
2015-10-23 17:47 ` [iproute RFC PATCH 3/9] tc: add a man page for flow filter Phil Sutter
2015-10-23 17:47 ` [iproute RFC PATCH 4/9] tc: add a man page for flower filter Phil Sutter
2015-10-23 17:47 ` [iproute RFC PATCH 5/9] tc: add a man page for fw filter Phil Sutter
2015-10-23 17:47 ` [iproute RFC PATCH 6/9] tc: add a man page for route filter Phil Sutter
2015-10-23 17:47 ` [iproute RFC PATCH 7/9] tc: add a man page for tcindex filter Phil Sutter
2015-10-23 17:47 ` [iproute RFC PATCH 8/9] tc: add a man page for u32 filter Phil Sutter
2015-10-23 17:47 ` [iproute RFC PATCH 9/9] tc: ship filter man pages and refer to them in tc.8 Phil Sutter
2015-10-23 20:13 ` [iproute RFC PATCH 0/9] Document tc filters Thomas Graf
2015-10-23 22:19 ` Phil Sutter
2015-10-23 22:41 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151023154112.7e57c730@xeon-e3 \
--to=shemming@brocade.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).