From: kbuild test robot <lkp@intel.com>
To: LABBE Corentin <clabbe.montjoie@gmail.com>
Cc: kbuild-all@01.org, davem@davemloft.net, jmorris@namei.org,
kaber@trash.net, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org,
LABBE Corentin <clabbe.montjoie@gmail.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 10/11] net: ipv4: hlen could be set as size_t
Date: Fri, 23 Oct 2015 20:43:41 +0800 [thread overview]
Message-ID: <201510232008.yu1Fixf6%fengguang.wu@intel.com> (raw)
In-Reply-To: <1445602236-24130-11-git-send-email-clabbe.montjoie@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3399 bytes --]
Hi LABBE,
[auto build test WARNING on net/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base]
url: https://github.com/0day-ci/linux/commits/LABBE-Corentin/net-change-len-parameter-type-for-memcpy_-to-from-_msg/20151023-201642
config: xtensa-allyesconfig (attached as .config)
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=xtensa
All warnings (new ones prefixed by >>):
In file included from include/asm-generic/bug.h:13:0,
from arch/xtensa/include/generated/asm/bug.h:1,
from include/linux/bug.h:4,
from include/linux/thread_info.h:11,
from arch/xtensa/include/asm/current.h:16,
from net/ipv4/raw.c:43:
net/ipv4/raw.c: In function 'raw_getfrag':
include/linux/kernel.h:722:17: warning: comparison of distinct pointer types lacks a cast
(void) (&_min1 == &_min2); \
^
>> net/ipv4/raw.c:458:14: note: in expansion of macro 'min'
int copy = min(rfv->hlen - offset, len);
^
vim +/min +458 net/ipv4/raw.c
b61e9dcc5 Al Viro 2014-11-24 442 err = memcpy_from_msg(rfv->hdr.c, rfv->msg, rfv->hlen);
32b5913a9 Herbert Xu 2014-11-07 443 if (err)
32b5913a9 Herbert Xu 2014-11-07 444 return err;
^1da177e4 Linus Torvalds 2005-04-16 445
c008ba5bd Herbert Xu 2014-11-07 446 fl4->fl4_icmp_type = rfv->hdr.icmph.type;
c008ba5bd Herbert Xu 2014-11-07 447 fl4->fl4_icmp_code = rfv->hdr.icmph.code;
^1da177e4 Linus Torvalds 2005-04-16 448
a27b58fed Heiko Carstens 2006-10-30 449 return 0;
^1da177e4 Linus Torvalds 2005-04-16 450 }
^1da177e4 Linus Torvalds 2005-04-16 451
c008ba5bd Herbert Xu 2014-11-07 452 static int raw_getfrag(void *from, char *to, int offset, int len, int odd,
c008ba5bd Herbert Xu 2014-11-07 453 struct sk_buff *skb)
c008ba5bd Herbert Xu 2014-11-07 454 {
c008ba5bd Herbert Xu 2014-11-07 455 struct raw_frag_vec *rfv = from;
c008ba5bd Herbert Xu 2014-11-07 456
c008ba5bd Herbert Xu 2014-11-07 457 if (offset < rfv->hlen) {
c008ba5bd Herbert Xu 2014-11-07 @458 int copy = min(rfv->hlen - offset, len);
c008ba5bd Herbert Xu 2014-11-07 459
c008ba5bd Herbert Xu 2014-11-07 460 if (skb->ip_summed == CHECKSUM_PARTIAL)
c008ba5bd Herbert Xu 2014-11-07 461 memcpy(to, rfv->hdr.c + offset, copy);
c008ba5bd Herbert Xu 2014-11-07 462 else
c008ba5bd Herbert Xu 2014-11-07 463 skb->csum = csum_block_add(
c008ba5bd Herbert Xu 2014-11-07 464 skb->csum,
c008ba5bd Herbert Xu 2014-11-07 465 csum_partial_copy_nocheck(rfv->hdr.c + offset,
c008ba5bd Herbert Xu 2014-11-07 466 to, copy, 0),
:::::: The code at line 458 was first introduced by commit
:::::: c008ba5bdc9fa830e1a349b20b0be5a137bdef7a ipv4: Avoid reading user iov twice after raw_probe_proto_opt
:::::: TO: Herbert Xu <herbert@gondor.apana.org.au>
:::::: CC: David S. Miller <davem@davemloft.net>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 42431 bytes --]
next prev parent reply other threads:[~2015-10-23 12:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 12:10 (unknown), LABBE Corentin
2015-10-23 12:10 ` [PATCH 02/11] net: llc: fix a setting of error value to size_t LABBE Corentin
2015-10-23 12:10 ` [PATCH 03/11] net: llc: change copied to size_t in llc_ui_sendmsg LABBE Corentin
2015-10-23 12:10 ` [PATCH 04/11] net: packet: change vnet_hdr_len from int to size_t LABBE Corentin
2015-10-23 13:35 ` Michael S. Tsirkin
2015-10-23 12:10 ` [PATCH 05/11] net: irda: change chunk " LABBE Corentin
2015-10-23 12:10 ` [PATCH 06/11] net: ipv6: set the length parameter of rawv6_send_hdrinc() " LABBE Corentin
2015-10-23 12:10 ` [PATCH 07/11] net: caif: change chunk from int " LABBE Corentin
2015-10-23 12:10 ` [PATCH 08/11] net: bluetooth: change the len parameter of sco_send_frame() " LABBE Corentin
2015-10-23 12:30 ` kbuild test robot
2015-10-23 12:36 ` kbuild test robot
2015-10-23 12:40 ` kbuild test robot
2015-10-25 19:54 ` Marcel Holtmann
2015-10-23 12:10 ` [PATCH 09/11] net: ipv6: hlen could be set as size_t LABBE Corentin
2015-10-23 12:33 ` kbuild test robot
2015-10-23 12:46 ` kbuild test robot
2015-10-23 12:10 ` [PATCH 10/11] net: ipv4: " LABBE Corentin
2015-10-23 12:43 ` kbuild test robot [this message]
2015-10-23 13:08 ` David Miller
2015-10-23 13:21 ` LABBE Corentin
2015-10-23 13:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201510232008.yu1Fixf6%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kbuild-all@01.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).