From: Mike Frysinger <vapier@gentoo.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: GNU C Library <libc-alpha@sourceware.org>,
Hannes Sowa <hannes@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] glibc: Terminate process on invalid netlink response from kernel [BZ #12926]
Date: Sat, 24 Oct 2015 00:22:03 -0400 [thread overview]
Message-ID: <20151024042203.GQ26317@vapier.lan> (raw)
In-Reply-To: <562A9391.1040806@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 492 bytes --]
On 23 Oct 2015 22:07, Florian Weimer wrote:
> --- /dev/null
> +++ b/sysdeps/unix/sysv/linux/netlink_assert_response.c
> @@ -0,0 +1,100 @@
> +/* Copyright (C) 2015 Free Software Foundation, Inc.
> + This file is part of the GNU C Library.
guess we like to have the first line be a short desc of the file
> +static int
> +get_address_family (int fd)
> +{
> ...
> + return sa.ss_family;
ss_family is of type sa_family_t, not int ... not a big deal, but the
two do differ in sign ...
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-10-24 4:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 20:07 [PATCH] glibc: Terminate process on invalid netlink response from kernel [BZ #12926] Florian Weimer
2015-10-24 4:22 ` Mike Frysinger [this message]
2015-11-03 13:40 ` [PATCH v2] " Florian Weimer
2015-11-03 13:48 ` [PATCH] " Hannes Frederic Sowa
2015-11-03 14:00 ` Florian Weimer
2015-11-05 14:36 ` Hannes Frederic Sowa
2015-11-03 16:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151024042203.GQ26317@vapier.lan \
--to=vapier@gentoo.org \
--cc=fweimer@redhat.com \
--cc=hannes@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).