[net-next:master 1610/1613] net/tipc/link.c:176:5: sparse: symbol 'tipc_link_is_active' was not declared. Should it be static?

[net-next:master 1610/1613] net/tipc/link.c:176:5: sparse: symbol 'tipc_link_is_active' was not declared. Should it be static?

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head:   687f079addba1ac7f97ce97080c2291bbe8c8dce
commit: c72fa872a23f03b2b9c17e88f3b0a8070924e5f1 [1610/1613] tipc: eliminate link's reference to owner node
reproduce:
        # apt-get install sparse
        git checkout c72fa872a23f03b2b9c17e88f3b0a8070924e5f1
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

   net/tipc/link.c:166:6: sparse: symbol 'link_is_bc_sndlink' was not declared. Should it be static?
   net/tipc/link.c:171:6: sparse: symbol 'link_is_bc_rcvlink' was not declared. Should it be static?
>> net/tipc/link.c:176:5: sparse: symbol 'tipc_link_is_active' was not declared. Should it be static?
   net/tipc/link.c:648:6: sparse: symbol 'link_prepare_wakeup' was not declared. Should it be static?
   net/tipc/link.c:904:6: sparse: symbol 'tipc_link_advance_backlog' was not declared. Should it be static?
   net/tipc/link.c:980:5: sparse: symbol 'tipc_link_retrans' was not declared. Should it be static?
   net/tipc/link.c:1573:6: sparse: symbol 'tipc_link_build_bc_init_msg' was not declared. Should it be static?
   include/linux/rcupdate.h:305:9: sparse: context imbalance in 'tipc_link_find_owner' - wrong count at exit
   net/tipc/link.c:1833:5: sparse: context imbalance in 'tipc_nl_link_set' - different lock contexts for basic block
   net/tipc/link.c:2070:5: sparse: context imbalance in 'tipc_nl_link_dump' - different lock contexts for basic block
   net/tipc/link.c:2141:5: sparse: context imbalance in 'tipc_nl_link_get' - different lock contexts for basic block
   net/tipc/link.c:2193:5: sparse: context imbalance in 'tipc_nl_link_reset_stats' - different lock contexts for basic block

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[RFC PATCH net-next] tipc: tipc_link_is_active() can be static

[kbuild test robot]

TO: "David S. Miller" <davem@davemloft.net>
CC: netdev@vger.kernel.org
CC: Jon Maloy <jon.maloy@ericsson.com>
CC: Ying Xue <ying.xue@windriver.com>
CC: tipc-discussion@lists.sourceforge.net
CC: linux-kernel@vger.kernel.org


Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 link.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/tipc/link.c b/net/tipc/link.c
index 4449fa0..b637276 100644
--- a/net/tipc/link.c
+++ b/net/tipc/link.c
@@ -173,7 +173,7 @@ bool link_is_bc_rcvlink(struct tipc_link *l)
 	return ((l->bc_rcvlink == l) && !link_is_bc_sndlink(l));
 }
 
-int tipc_link_is_active(struct tipc_link *l)
+static int tipc_link_is_active(struct tipc_link *l)
 {
 	return l->active;
 }

RE: [RFC PATCH net-next] tipc: tipc_link_is_active() can be static

[Jon Maloy]

Acked-by: Jon Maloy <jon.maloy@ericsson.com>



> -----Original Message-----
> From: netdev-owner@vger.kernel.org [mailto:netdev-
> owner@vger.kernel.org] On Behalf Of kbuild test robot
> Sent: Saturday, 24 October, 2015 11:11
> To: kbuild-internal@linux.intel.com; lkp@eclists.intel.com
> Cc: kbuild-all@01.org; netdev@vger.kernel.org
> Subject: [RFC PATCH net-next] tipc: tipc_link_is_active() can be static
> 
> TO: "David S. Miller" <davem@davemloft.net>
> CC: netdev@vger.kernel.org
> CC: Jon Maloy <jon.maloy@ericsson.com>
> CC: Ying Xue <ying.xue@windriver.com>
> CC: tipc-discussion@lists.sourceforge.net
> CC: linux-kernel@vger.kernel.org
> 
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>  link.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/tipc/link.c b/net/tipc/link.c index 4449fa0..b637276 100644
> --- a/net/tipc/link.c
> +++ b/net/tipc/link.c
> @@ -173,7 +173,7 @@ bool link_is_bc_rcvlink(struct tipc_link *l)
>  	return ((l->bc_rcvlink == l) && !link_is_bc_sndlink(l));  }
> 
> -int tipc_link_is_active(struct tipc_link *l)
> +static int tipc_link_is_active(struct tipc_link *l)
>  {
>  	return l->active;
>  }
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in the body
> of a message to majordomo@vger.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH net-next] tipc: tipc_link_is_active() can be static

[David Miller]

From: kbuild test robot <fengguang.wu@intel.com>
Date: Sat, 24 Oct 2015 23:11:00 +0800

> TO: "David S. Miller" <davem@davemloft.net>
> CC: netdev@vger.kernel.org
> CC: Jon Maloy <jon.maloy@ericsson.com>
> CC: Ying Xue <ying.xue@windriver.com>
> CC: tipc-discussion@lists.sourceforge.net
> CC: linux-kernel@vger.kernel.org
> 
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Why doesn't the kbuild robot run on it's own changes? :-/

  CC [M]  net/tipc/link.o
net/tipc/link.c:176:12: warning: ‘tipc_link_is_active’ defined but not used [-Wunused-function]

Re: [RFC PATCH net-next] tipc: tipc_link_is_active() can be static

[Fengguang Wu]

On Sun, Oct 25, 2015 at 06:33:18AM -0700, David Miller wrote:
> From: kbuild test robot <fengguang.wu@intel.com>
> Date: Sat, 24 Oct 2015 23:11:00 +0800
> 
> > TO: "David S. Miller" <davem@davemloft.net>
> > CC: netdev@vger.kernel.org
> > CC: Jon Maloy <jon.maloy@ericsson.com>
> > CC: Ying Xue <ying.xue@windriver.com>
> > CC: tipc-discussion@lists.sourceforge.net
> > CC: linux-kernel@vger.kernel.org
> > 
> > 
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> 
> Why doesn't the kbuild robot run on it's own changes? :-/

It does, however it detects only build failures (which indicates a
false sparse warning) to avoid sending bad make-it-static patch
and the false warning.

The build warning looks easier to be discovered and fixed in the
larger loop of

        apply patch => git push => 0day build test

>   CC [M]  net/tipc/link.o
> net/tipc/link.c:176:12: warning: ‘tipc_link_is_active’ defined but not used [-Wunused-function]

If the robot detected the above warning, it'll still need to send the
report out. Otherwise we lose a chance to notice tipc_link_is_active()
is not used.

However it may be valuable to include possible new warnings inside
the patch changelog, so that maintainers can immediately see the
consequences of applying the patch.

Thanks,
Fengguang