From: David Miller <davem@davemloft.net>
To: aduyck@mirantis.com
Cc: netdev@vger.kernel.org, brak@gameservers.com
Subject: Re: [net PATCH] fib_trie: leaf_walk_rcu should not compute key if key is less than pn->key
Date: Tue, 27 Oct 2015 18:15:38 -0700 (PDT) [thread overview]
Message-ID: <20151027.181538.2065720176501734630.davem@davemloft.net> (raw)
In-Reply-To: <20151027220352.1312.18265.stgit@ahduyck-vm-fedora22>
From: Alexander Duyck <aduyck@mirantis.com>
Date: Tue, 27 Oct 2015 15:06:45 -0700
> We were computing the child index in cases where the key value we were
> looking for was actually less than the base key of the tnode. As a result
> we were getting incorrect index values that would cause us to skip over
> some children.
>
> To fix this I have added a test that will force us to use child index 0 if
> the key we are looking for is less than the key of the current tnode.
>
> Fixes: 8be33e955cb9 ("fib_trie: Fib walk rcu should take a tnode and key instead of a trie and a leaf")
> Reported-by: Brian Rak <brak@gameservers.com>
> Signed-off-by: Alexander Duyck <aduyck@mirantis.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2015-10-28 0:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 22:06 [net PATCH] fib_trie: leaf_walk_rcu should not compute key if key is less than pn->key Alexander Duyck
2015-10-28 0:18 ` Brian Rak
2015-10-28 1:15 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151027.181538.2065720176501734630.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aduyck@mirantis.com \
--cc=brak@gameservers.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).