From: David Miller <davem@davemloft.net>
To: joestringer@nicira.com
Cc: netdev@vger.kernel.org, fw@strlen.de, pablo@netfilter.org,
azhou@nicira.com
Subject: Re: [PATCHv3 net 3/3] openvswitch: Fix skb leak using IPv6 defrag
Date: Tue, 27 Oct 2015 19:32:59 -0700 (PDT) [thread overview]
Message-ID: <20151027.193259.1057135403867772523.davem@davemloft.net> (raw)
In-Reply-To: <1445829710-11292-3-git-send-email-joestringer@nicira.com>
From: Joe Stringer <joestringer@nicira.com>
Date: Sun, 25 Oct 2015 20:21:50 -0700
> nf_ct_frag6_gather() makes a clone of each skb passed to it, and if the
> reassembly is successful, expects the caller to free all of the original
> skbs using nf_ct_frag6_consume_orig(). This call was previously missing,
> meaning that the original fragments were never freed (with the exception
> of the last fragment to arrive).
>
> Fix this by ensuring that all original fragments except for the last
> fragment are freed via nf_ct_frag6_consume_orig(). The last fragment
> will be morphed into the head, so it must not be freed yet. Furthermore,
> retain the ->next pointer for the head after skb_morph().
>
> Fixes: 7f8a436eaa2c ("openvswitch: Add conntrack action")
> Reported-by: Florian Westphal <fw@strlen.de>
> Signed-off-by: Joe Stringer <joestringer@nicira.com>
Applied.
next prev parent reply other threads:[~2015-10-28 2:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 3:21 [PATCHv3 net 1/3] openvswitch: Fix double-free on ip_defrag() errors Joe Stringer
2015-10-26 3:21 ` [PATCHv3 net 2/3] ipv6: Export nf_ct_frag6_consume_orig() Joe Stringer
2015-10-27 21:29 ` Pravin Shelar
2015-10-28 2:32 ` David Miller
2015-10-26 3:21 ` [PATCHv3 net 3/3] openvswitch: Fix skb leak using IPv6 defrag Joe Stringer
2015-10-27 21:30 ` Pravin Shelar
2015-10-28 2:32 ` David Miller [this message]
2015-10-27 21:29 ` [PATCHv3 net 1/3] openvswitch: Fix double-free on ip_defrag() errors Pravin Shelar
2015-10-28 2:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151027.193259.1057135403867772523.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=azhou@nicira.com \
--cc=fw@strlen.de \
--cc=joestringer@nicira.com \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).