From: Richard Cochran <richardcochran@gmail.com>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] sock: don't enable netstamp for af_unix sockets
Date: Tue, 27 Oct 2015 11:11:58 +0100 [thread overview]
Message-ID: <20151027101157.GA1850@netboy> (raw)
In-Reply-To: <1445866379.133031.420389177.3AE9E175@webmail.messagingengine.com>
On Mon, Oct 26, 2015 at 02:32:59PM +0100, Hannes Frederic Sowa wrote:
> On Mon, Oct 26, 2015, at 14:19, Richard Cochran wrote:
> > On Mon, Oct 26, 2015 at 01:51:37PM +0100, Hannes Frederic Sowa wrote:
> > > netstamp_needed is toggled for all socket families if they request
> > > timestamping. But some protocols don't need the lower-layer timestamping
> > > code at all. This patch starts disabling it for af-unix.
> >
> > What problem is this patch trying to solve?
>
> netstamp_needed is a static-key which enables timestamping code in the
> networking stack receive functions for every packet, while it is not
> needed for AF_UNIX/LOCAL. So it is merely a small performance
> enhancement.
Are there any numbers that show the effect of this enhancement?
Thanks,
Richard
next prev parent reply other threads:[~2015-10-27 10:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 12:51 [PATCH net-next] sock: don't enable netstamp for af_unix sockets Hannes Frederic Sowa
2015-10-26 13:19 ` Richard Cochran
2015-10-26 13:32 ` Hannes Frederic Sowa
2015-10-27 10:11 ` Richard Cochran [this message]
2015-10-27 11:09 ` Hannes Frederic Sowa
2015-10-27 11:15 ` Hannes Frederic Sowa
2015-10-27 12:04 ` Jesper Dangaard Brouer
2015-10-27 13:19 ` Eric Dumazet
2015-10-27 13:44 ` Hannes Frederic Sowa
2015-10-27 14:15 ` Eric Dumazet
2015-10-28 2:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151027101157.GA1850@netboy \
--to=richardcochran@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).