netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Neal P. Murphy" <neal.p.murphy@alum.wpi.edu>
To: Ani Sinha <ani@arista.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
	netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] commit c6825c0976fa7893692e0e43b09740b419b23c09 upstream.
Date: Wed, 28 Oct 2015 02:36:50 -0400	[thread overview]
Message-ID: <20151028023650.7b76098f@playground> (raw)
In-Reply-To: <20151026200633.GA13476@salvia>

On Mon, 26 Oct 2015 21:06:33 +0100
Pablo Neira Ayuso <pablo@netfilter.org> wrote:

> Hi,
> 
> On Mon, Oct 26, 2015 at 11:55:39AM -0700, Ani Sinha wrote:
> > netfilter: nf_conntrack: fix RCU race in nf_conntrack_find_get
> 
> Please, no need to Cc everyone here. Please, submit your Netfilter
> patches to netfilter-devel@vger.kernel.org.
> 
> Moreover, it would be great if the subject includes something
> descriptive on what you need, for this I'd suggest:
> 
> [PATCH -stable 3.4,backport] netfilter: nf_conntrack: fix RCU race in nf_conntrack_find_get
> 
> I'm including Neal P. Murphy, he said he would help testing these
> backports, getting a Tested-by: tag usually speeds up things too.

I hammered it a couple nights ago. First test was 5000 processes on 6 SMP CPUs opening and closing a port on a 'remote' host using the usual random source ports. Only got up to 32000 conntracks. The generator was a 64-bit Smoothwall KVM without the patch. The traffic passed through a 32-bit Smoothwall KVM with the patch. The target was on the VM host. No problems encountered. I suspect I didn't come close to triggering the original problem. Second test was a couple thousand processes all using the same source IP and port and dest IP and port. Still no problems. But these were perl scripts (and they used lots of RAM); perhaps a short C program would let me run more.

Any ideas on how I might test it more brutally?

N

  reply	other threads:[~2015-10-28  6:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-26 18:55 [PATCH 1/1] commit c6825c0976fa7893692e0e43b09740b419b23c09 upstream Ani Sinha
2015-10-26 20:06 ` Pablo Neira Ayuso
2015-10-28  6:36   ` Neal P. Murphy [this message]
     [not found]   ` <17709_1446014232_t9S6b5a3017652_20151028023650.7b76098f@playground>
2015-10-29  6:40     ` Neal P. Murphy
2015-10-30  0:01       ` Ani Sinha
2015-10-30  1:21         ` Neal P. Murphy
2015-10-30 15:37           ` Ani Sinha
2015-11-02 19:11   ` [PATCH -stable 3.4,backport] " Ani Sinha
2015-11-02 19:47   ` Ani Sinha
2015-11-04 23:46   ` [PATCH 1/1] " Ani Sinha
2015-11-06 11:09     ` Pablo Neira Ayuso
  -- strict thread matches above, loose matches on Subject: below --
2015-11-02 20:48 Ani Sinha
2015-10-24 18:27 Ani Sinha
2015-10-24 18:31 ` Ani Sinha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151028023650.7b76098f@playground \
    --to=neal.p.murphy@alum.wpi.edu \
    --cc=ani@arista.com \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=netfilter@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).