From: Sabrina Dubroca <sd@queasysnail.net>
To: netdev@vger.kernel.org
Cc: herbert@gondor.apana.org.au, stable@vger.kernel.org,
hannes@stressinduktion.org
Subject: Re: [PATCH stable <= 3.18] net: add length argument to skb_copy_and_csum_datagram_iovec
Date: Thu, 29 Oct 2015 11:00:21 +0100 [thread overview]
Message-ID: <20151029100021.GA17588@bistromath.redhat.com> (raw)
In-Reply-To: <c1b23313f94ba3fd9977c6fba61483edf6489b5f.1444910940.git.sd@queasysnail.net>
2015-10-15, 14:25:03 +0200, Sabrina Dubroca wrote:
> Without this length argument, we can read past the end of the iovec in
> memcpy_toiovec because we have no way of knowing the total length of the
> iovec's buffers.
>
> This is needed for stable kernels where 89c22d8c3b27 ("net: Fix skb
> csum races when peeking") has been backported but that don't have the
> ioviter conversion, which is almost all the stable trees <= 3.18.
>
> This also fixes a kernel crash for NFS servers when the client uses
> -onfsvers=3,proto=udp to mount the export.
>
> Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
> Reviewed-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Fixes CVE-2015-8019.
http://www.openwall.com/lists/oss-security/2015/10/29/1
--
Sabrina
next prev parent reply other threads:[~2015-10-29 10:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 12:25 [PATCH stable <= 3.18] net: add length argument to skb_copy_and_csum_datagram_iovec Sabrina Dubroca
2015-10-29 10:00 ` Sabrina Dubroca [this message]
2015-11-10 23:59 ` Josh Hunt
2015-11-11 0:03 ` Greg Kroah-Hartman
2015-11-12 9:48 ` Sabrina Dubroca
2015-11-12 17:26 ` Eric Dumazet
2015-11-16 18:06 ` Sabrina Dubroca
2015-11-13 21:29 ` David Miller
2015-11-14 17:39 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151029100021.GA17588@bistromath.redhat.com \
--to=sd@queasysnail.net \
--cc=hannes@stressinduktion.org \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).