From: Andrew Lunn <andrew@lunn.ch>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Guenter Roeck <linux@roeck-us.net>,
Fabian Frederick <fabf@skynet.be>,
Pavel Nakonechny <pavel.nakonechny@skitlab.ru>,
Joe Perches <joe@perches.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Frode Isaksen <fisaksen@baylibre.com>
Subject: Re: [PATCH v2 1/6] net: dsa: Use delayed work instead of timer+work for polling
Date: Fri, 30 Oct 2015 17:30:07 +0100 [thread overview]
Message-ID: <20151030163007.GB8940@lunn.ch> (raw)
In-Reply-To: <5633904D.6060108@baylibre.com>
On Fri, Oct 30, 2015 at 04:44:13PM +0100, Neil Armstrong wrote:
> On 10/29/2015 04:28 PM, Andrew Lunn wrote:
> >> Is 6060 supported by the 6352 family? It doesn't share any mv88e6xxx
> >> code...
> >
> > It is a totally separate driver. Nothing shared at all.. It is an old
> > device, and only does 10/100. It could be it is just too different to
> > support via mv88e6xxx.
> >
> > Andrew
> >
>
> Andrew,
>
> The link detection still works without the polling for 6060, this will largely simplify the patchset.
>
> I will include a link poll callback removal in my 6060 cleanup patchset.
>
> Then I will include a poll_link removal in dsa.c instead of fixing it.
Great, always nice to see unneeded code removed.
Andrew
prev parent reply other threads:[~2015-10-30 16:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 13:22 [PATCH v2 1/6] net: dsa: Use delayed work instead of timer+work for polling Neil Armstrong
2015-10-29 13:51 ` Andrew Lunn
2015-10-29 14:10 ` Neil Armstrong
2015-10-29 14:40 ` Andrew Lunn
2015-10-29 14:52 ` Vivien Didelot
2015-10-29 15:28 ` Andrew Lunn
2015-10-30 15:44 ` Neil Armstrong
2015-10-30 16:30 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151030163007.GB8940@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=fabf@skynet.be \
--cc=fisaksen@baylibre.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=narmstrong@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=pavel.nakonechny@skitlab.ru \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).