From: David Miller <davem@davemloft.net>
To: p.fedin@samsung.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
steve.glendinning@shawell.net
Subject: Re: [PATCH] net: smsc911x: Reset PHY during initialization
Date: Sun, 01 Nov 2015 16:51:51 -0500 (EST) [thread overview]
Message-ID: <20151101.165151.1119828043753664843.davem@davemloft.net> (raw)
In-Reply-To: <1446188779-4184-1-git-send-email-p.fedin@samsung.com>
From: Pavel Fedin <p.fedin@samsung.com>
Date: Fri, 30 Oct 2015 10:06:19 +0300
> On certain hardware after software reboot the chip may get stuck and fail
> to reinitialize during reset. This can be fixed by ensuring that PHY is
> reset too.
>
> Old PHY resetting method required operational MDIO interface, therefore
> the chip should have been already set up. In order to be able to function
> during probe, it is changed to use PMT_CTRL register.
>
> The problem could be observed on SMDK5410 board.
>
> Signed-off-by: Pavel Fedin <p.fedin@samsung.com>
I'm pretty sure this is going to break the PHY loopback test.
This is such a tricky and fragile area to get right, therefore I
want you to specifically guard any change in how PHY reset is
done with tests against the specific chips that have the problem.
Furthermore, I want you to test whether this has any negative
effects on the PHY loopback test.
next prev parent reply other threads:[~2015-11-01 21:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 7:06 [PATCH] net: smsc911x: Reset PHY during initialization Pavel Fedin
2015-11-01 21:51 ` David Miller [this message]
2015-11-02 7:19 ` Pavel Fedin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151101.165151.1119828043753664843.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p.fedin@samsung.com \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).