From: Stephen Hemminger <shemming@brocade.com>
To: Phil Sutter <phil@nwl.cc>
Cc: <netdev@vger.kernel.org>
Subject: Re: [iproute PATCH] iproute: fix filter_nlmsg
Date: Tue, 3 Nov 2015 16:33:59 -0800 [thread overview]
Message-ID: <20151103163359.0a38d573@xeon-e3> (raw)
In-Reply-To: <1446117347-9110-1-git-send-email-phil@nwl.cc>
On Thu, 29 Oct 2015 12:15:47 +0100
Phil Sutter <phil@nwl.cc> wrote:
> This patch is based upon an old Fedora bug[1] regarding the routing
> setup of PPP links. I'm not quite sure if it still applies today or how
> to trigger it, but looking at the change introducing this, it's
> obviously a bug.
>
> [1] https://bugzilla.redhat.com/show_bug.cgi?id=622782
>
> Fixes: 4479282 ("iproute2: filter routing entries based on clone flag")
> Signed-off-by: Phil Sutter <phil@nwl.cc>
> ---
> ip/iproute.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ip/iproute.c b/ip/iproute.c
> index eab512d..ea7e9aa 100644
> --- a/ip/iproute.c
> +++ b/ip/iproute.c
> @@ -151,7 +151,7 @@ static int filter_nlmsg(struct nlmsghdr *n, struct rtattr **tb, int host_len)
> if (r->rtm_family == AF_INET6 && table != RT_TABLE_MAIN)
> ip6_multiple_tables = 1;
>
> - if (filter.cloned == !(r->rtm_flags&RTM_F_CLONED))
> + if (filter.cloned && !(r->rtm_flags&RTM_F_CLONED))
> return 0;
>
> if (r->rtm_family == AF_INET6 && !ip6_multiple_tables) {
Holding off on this, until there is an obvious reproduction.
The patch looks right but this code has been around a long time and don't want
any surprised users.
next prev parent reply other threads:[~2015-11-04 0:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 11:15 [iproute PATCH] iproute: fix filter_nlmsg Phil Sutter
2015-11-04 0:33 ` Stephen Hemminger [this message]
2015-11-04 15:54 ` Phil Sutter
2015-11-24 0:20 ` Stephen Hemminger
2015-11-24 12:40 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151103163359.0a38d573@xeon-e3 \
--to=shemming@brocade.com \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).