From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [iproute PATCH] iproute: fix filter_nlmsg Date: Tue, 3 Nov 2015 16:33:59 -0800 Message-ID: <20151103163359.0a38d573@xeon-e3> References: <1446117347-9110-1-git-send-email-phil@nwl.cc> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Cc: To: Phil Sutter Return-path: Received: from mx0b-000f0801.pphosted.com ([67.231.152.113]:4161 "EHLO mx0b-000f0801.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755445AbbKDAdw (ORCPT ); Tue, 3 Nov 2015 19:33:52 -0500 In-Reply-To: <1446117347-9110-1-git-send-email-phil@nwl.cc> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 29 Oct 2015 12:15:47 +0100 Phil Sutter wrote: > This patch is based upon an old Fedora bug[1] regarding the routing > setup of PPP links. I'm not quite sure if it still applies today or how > to trigger it, but looking at the change introducing this, it's > obviously a bug. > > [1] https://bugzilla.redhat.com/show_bug.cgi?id=622782 > > Fixes: 4479282 ("iproute2: filter routing entries based on clone flag") > Signed-off-by: Phil Sutter > --- > ip/iproute.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ip/iproute.c b/ip/iproute.c > index eab512d..ea7e9aa 100644 > --- a/ip/iproute.c > +++ b/ip/iproute.c > @@ -151,7 +151,7 @@ static int filter_nlmsg(struct nlmsghdr *n, struct rtattr **tb, int host_len) > if (r->rtm_family == AF_INET6 && table != RT_TABLE_MAIN) > ip6_multiple_tables = 1; > > - if (filter.cloned == !(r->rtm_flags&RTM_F_CLONED)) > + if (filter.cloned && !(r->rtm_flags&RTM_F_CLONED)) > return 0; > > if (r->rtm_family == AF_INET6 && !ip6_multiple_tables) { Holding off on this, until there is an obvious reproduction. The patch looks right but this code has been around a long time and don't want any surprised users.