From: Sabrina Dubroca <sd@queasysnail.net>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, dvyukov@google.com,
hannes@stressinduktion.org, cwang@twopensource.com
Subject: Re: [PATCH net v2] ipv6: clean up dev_snmp6 proc entry when we fail to initialize inet6_dev
Date: Wed, 4 Nov 2015 16:36:54 +0100 [thread overview]
Message-ID: <20151104153654.GA22004@bistromath.redhat.com> (raw)
In-Reply-To: <1446650594.4184.25.camel@edumazet-glaptop2.roam.corp.google.com>
2015-11-04, 07:23:14 -0800, Eric Dumazet wrote:
> On Wed, 2015-11-04 at 14:47 +0100, Sabrina Dubroca wrote:
> > In ipv6_add_dev, when addrconf_sysctl_register fails, we do not clean up
> > the dev_snmp6 entry that we have already registered for this device.
> > Call snmp6_unregister_dev in this case.
> >
> > Reported-by: Dmitry Vyukov <dvyukov@google.com>
> > Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
> > ---
> >
> > v2: we cannot call snmp6_unregister_dev from addrconf_core.c, this
> > breaks CONFIG_IPV6=m, instead do the clean up directly from
> > ipv6_add_dev
> > thanks Cong.
>
> Any idea when the bug was added ?
>
> Can we please add a proper Fixes: tag for patches that need to be
> backported to stable versions ?
>
> It seems to be
>
> Fixes: a317a2f19da7d ("ipv6: fail early when creating netdev named all or default")
>
> So this goes back to linux-3.17 ?
>
> Thanks a lot Sabrina !
Sorry, I didn't do the archeology (well, run git blame). That looks
correct, thanks Eric.
--
Sabrina
next prev parent reply other threads:[~2015-11-04 15:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 13:47 [PATCH net v2] ipv6: clean up dev_snmp6 proc entry when we fail to initialize inet6_dev Sabrina Dubroca
2015-11-04 15:23 ` Eric Dumazet
2015-11-04 15:36 ` Sabrina Dubroca [this message]
2015-11-05 4:56 ` [PATCH net v3] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151104153654.GA22004@bistromath.redhat.com \
--to=sd@queasysnail.net \
--cc=cwang@twopensource.com \
--cc=dvyukov@google.com \
--cc=eric.dumazet@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).