From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: "Shi, Yang" <yang.shi@linaro.org>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
ast@kernel.org, daniel@iogearbox.net, catalin.marinas@arm.com,
will.deacon@arm.com, zlim.lnx@gmail.com, xi.wang@gmail.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linaro-kernel@lists.linaro.org
Subject: Re: [PATCH 2/2] arm64: bpf: add BPF XADD instruction
Date: Tue, 10 Nov 2015 16:42:09 -0800 [thread overview]
Message-ID: <20151111004208.GA47378@ast-mbp.thefacebook.com> (raw)
In-Reply-To: <56428B1A.5090303@linaro.org>
On Tue, Nov 10, 2015 at 04:26:02PM -0800, Shi, Yang wrote:
> On 11/10/2015 4:08 PM, Eric Dumazet wrote:
> >On Tue, 2015-11-10 at 14:41 -0800, Yang Shi wrote:
> >>aarch64 doesn't have native support for XADD instruction, implement it by
> >>the below instruction sequence:
> >>
> >>Load (dst + off) to a register
> >>Add src to it
> >>Store it back to (dst + off)
> >
> >Not really what is needed ?
> >
> >See this BPF_XADD as an atomic_add() equivalent.
>
> I see. Thanks. The documentation doesn't say too much about "exclusive" add.
> If so it should need load-acquire/store-release.
I think doc is clear enough, but it can always be improved. Pls suggest a patch.
It's quite hard to write a test for atomicity in test_bpf framework, so
code review is the key. Eric, thanks for catching it!
next prev parent reply other threads:[~2015-11-11 0:42 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 22:41 [PATCH 0/2] arm64: bpf: add BPF_ST and BPF_XADD instructions support Yang Shi
2015-11-10 22:41 ` [PATCH 1/2] arm64: bpf: add 'store immediate' instruction Yang Shi
2015-11-11 2:45 ` Z Lim
2015-11-11 12:12 ` Will Deacon
2015-11-11 12:39 ` Will Deacon
2015-11-12 19:33 ` Shi, Yang
2015-11-13 3:45 ` Z Lim
2015-11-23 19:34 ` Shi, Yang
2015-11-10 22:41 ` [PATCH 2/2] arm64: bpf: add BPF XADD instruction Yang Shi
2015-11-11 0:08 ` Eric Dumazet
2015-11-11 0:26 ` Shi, Yang
2015-11-11 0:42 ` Alexei Starovoitov [this message]
2015-11-11 2:52 ` Z Lim
2015-11-11 8:49 ` Arnd Bergmann
2015-11-11 10:24 ` Will Deacon
2015-11-11 10:42 ` Daniel Borkmann
2015-11-11 11:58 ` Will Deacon
2015-11-11 12:21 ` Daniel Borkmann
2015-11-11 12:38 ` Will Deacon
2015-11-11 12:58 ` Peter Zijlstra
2015-11-11 15:52 ` Daniel Borkmann
2015-11-11 16:23 ` Will Deacon
2015-11-11 17:27 ` Alexei Starovoitov
2015-11-11 17:35 ` David Miller
2015-11-11 17:44 ` Will Deacon
2015-11-11 19:01 ` David Miller
2015-11-11 17:57 ` Peter Zijlstra
2015-11-11 18:11 ` Alexei Starovoitov
2015-11-11 18:31 ` Peter Zijlstra
2015-11-11 18:41 ` Peter Zijlstra
2015-11-11 18:44 ` Peter Zijlstra
2015-11-11 18:54 ` Peter Zijlstra
2015-11-11 19:55 ` Alexei Starovoitov
2015-11-11 22:21 ` Peter Zijlstra
2015-11-11 23:40 ` Alexei Starovoitov
2015-11-12 8:57 ` Peter Zijlstra
2015-11-11 18:50 ` Daniel Borkmann
2015-11-11 19:04 ` David Miller
2015-11-11 19:23 ` Peter Zijlstra
2015-11-11 19:41 ` Daniel Borkmann
2015-11-11 18:46 ` Will Deacon
2015-11-11 19:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151111004208.GA47378@ast-mbp.thefacebook.com \
--to=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=daniel@iogearbox.net \
--cc=eric.dumazet@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=will.deacon@arm.com \
--cc=xi.wang@gmail.com \
--cc=yang.shi@linaro.org \
--cc=zlim.lnx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).