From: Stephen Hemminger <stephen@networkplumber.org>
To: Alexander Duyck <aduyck@mirantis.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
jeffrey.t.kirsher@intel.com
Subject: Re: [net-next PATCH 2/3] ixgbe: Use __dev_uc_sync and __dev_uc_unsync for unicast addresses
Date: Wed, 11 Nov 2015 17:35:57 -0800 [thread overview]
Message-ID: <20151111173557.6eb25df5@xeon-e3> (raw)
In-Reply-To: <20151022232636.24612.12045.stgit@ahduyck-vm-fedora22>
On Thu, 22 Oct 2015 16:26:36 -0700
Alexander Duyck <aduyck@mirantis.com> wrote:
> +static int ixgbe_uc_unsync(struct net_device *netdev, const unsigned char *addr)
> +{
> + struct ixgbe_adapter *adapter = netdev_priv(netdev);
> +
> + ixgbe_del_mac_filter(adapter, addr, VMDQ_P(0));
> +
> + return 0;
Why add an internal function that always returns 0?
Rather than making it void.
next prev parent reply other threads:[~2015-11-12 1:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 23:26 [net-next PATCH 0/3] ixgbe: Fix FDB handling Alexander Duyck
2015-10-22 23:26 ` [net-next PATCH 1/3] ixgbe: Refactor MAC address configuration code Alexander Duyck
2015-11-11 23:34 ` [Intel-wired-lan] " Miller, Darin J
2015-10-22 23:26 ` [net-next PATCH 2/3] ixgbe: Use __dev_uc_sync and __dev_uc_unsync for unicast addresses Alexander Duyck
2015-11-04 18:39 ` [Intel-wired-lan] " Miller, Darin J
2015-11-12 1:35 ` Stephen Hemminger [this message]
2015-11-12 5:21 ` Alexander Duyck
2015-10-22 23:26 ` [net-next PATCH 3/3] ixgbe: Allow FDB entries access to more RAR filters Alexander Duyck
2015-11-04 18:40 ` [Intel-wired-lan] " Miller, Darin J
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151111173557.6eb25df5@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=aduyck@mirantis.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).