From: Peter Zijlstra <peterz@infradead.org>
To: David Miller <davem@davemloft.net>
Cc: alexei.starovoitov@gmail.com, will.deacon@arm.com,
daniel@iogearbox.net, arnd@arndb.de, yang.shi@linaro.org,
linaro-kernel@lists.linaro.org, eric.dumazet@gmail.com,
zlim.lnx@gmail.com, ast@kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, xi.wang@gmail.com,
catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org,
yhs@plumgrid.com, bblanco@plumgrid.com
Subject: Re: [PATCH 2/2] arm64: bpf: add BPF XADD instruction
Date: Wed, 11 Nov 2015 18:57:41 +0100 [thread overview]
Message-ID: <20151111175741.GR17308@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20151111.123548.1039494689070388545.davem@davemloft.net>
On Wed, Nov 11, 2015 at 12:35:48PM -0500, David Miller wrote:
> From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
> Date: Wed, 11 Nov 2015 09:27:00 -0800
>
> > BPF_XADD == atomic_add() in kernel. period.
> > we are not going to deprecate it or introduce something else.
>
> Agreed, it makes no sense to try and tie C99 or whatever atomic
> semantics to something that is already clearly defined to have
> exactly kernel atomic_add() semantics.
Dave, this really doesn't make any sense to me. __sync primitives have
well defined semantics and (e)BPF is violating this.
Furthermore, the fetch_and_add (or XADD) name has well defined
semantics, which (e)BPF also violates.
Atomicy is hard enough as it is, backends giving random interpretations
to them isn't helping anybody.
It also baffles me that Alexei is seemingly unwilling to change/rev the
(e)BPF instructions, which would be invisible to the regular user, he
does want to change the language itself, which will impact all
'scripts'.
next prev parent reply other threads:[~2015-11-11 17:57 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 22:41 [PATCH 0/2] arm64: bpf: add BPF_ST and BPF_XADD instructions support Yang Shi
2015-11-10 22:41 ` [PATCH 1/2] arm64: bpf: add 'store immediate' instruction Yang Shi
2015-11-11 2:45 ` Z Lim
2015-11-11 12:12 ` Will Deacon
2015-11-11 12:39 ` Will Deacon
2015-11-12 19:33 ` Shi, Yang
2015-11-13 3:45 ` Z Lim
2015-11-23 19:34 ` Shi, Yang
2015-11-10 22:41 ` [PATCH 2/2] arm64: bpf: add BPF XADD instruction Yang Shi
2015-11-11 0:08 ` Eric Dumazet
2015-11-11 0:26 ` Shi, Yang
2015-11-11 0:42 ` Alexei Starovoitov
2015-11-11 2:52 ` Z Lim
2015-11-11 8:49 ` Arnd Bergmann
2015-11-11 10:24 ` Will Deacon
2015-11-11 10:42 ` Daniel Borkmann
2015-11-11 11:58 ` Will Deacon
2015-11-11 12:21 ` Daniel Borkmann
2015-11-11 12:38 ` Will Deacon
2015-11-11 12:58 ` Peter Zijlstra
2015-11-11 15:52 ` Daniel Borkmann
2015-11-11 16:23 ` Will Deacon
2015-11-11 17:27 ` Alexei Starovoitov
2015-11-11 17:35 ` David Miller
2015-11-11 17:44 ` Will Deacon
2015-11-11 19:01 ` David Miller
2015-11-11 17:57 ` Peter Zijlstra [this message]
2015-11-11 18:11 ` Alexei Starovoitov
2015-11-11 18:31 ` Peter Zijlstra
2015-11-11 18:41 ` Peter Zijlstra
2015-11-11 18:44 ` Peter Zijlstra
2015-11-11 18:54 ` Peter Zijlstra
2015-11-11 19:55 ` Alexei Starovoitov
2015-11-11 22:21 ` Peter Zijlstra
2015-11-11 23:40 ` Alexei Starovoitov
2015-11-12 8:57 ` Peter Zijlstra
2015-11-11 18:50 ` Daniel Borkmann
2015-11-11 19:04 ` David Miller
2015-11-11 19:23 ` Peter Zijlstra
2015-11-11 19:41 ` Daniel Borkmann
2015-11-11 18:46 ` Will Deacon
2015-11-11 19:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151111175741.GR17308@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=alexei.starovoitov@gmail.com \
--cc=arnd@arndb.de \
--cc=ast@kernel.org \
--cc=bblanco@plumgrid.com \
--cc=catalin.marinas@arm.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=will.deacon@arm.com \
--cc=xi.wang@gmail.com \
--cc=yang.shi@linaro.org \
--cc=yhs@plumgrid.com \
--cc=zlim.lnx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).