From: David Miller <davem@davemloft.net>
To: hannes@cmpxchg.org
Cc: akpm@linux-foundation.org, vdavydov@virtuozzo.com, tj@kernel.org,
mhocko@suse.cz, netdev@vger.kernel.org, linux-mm@kvack.org,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH 04/14] net: tcp_memcontrol: remove bogus hierarchy pressure propagation
Date: Fri, 13 Nov 2015 11:00:26 -0500 (EST) [thread overview]
Message-ID: <20151113.110026.2097026445648423318.davem@davemloft.net> (raw)
In-Reply-To: <1447371693-25143-5-git-send-email-hannes@cmpxchg.org>
From: Johannes Weiner <hannes@cmpxchg.org>
Date: Thu, 12 Nov 2015 18:41:23 -0500
> When a cgroup currently breaches its socket memory limit, it enters
> memory pressure mode for itself and its *ancestors*. This throttles
> transmission in unrelated sibling and cousin subtrees that have
> nothing to do with the breached limit.
>
> On the contrary, breaching a limit should make that group and its
> *children* enter memory pressure mode. But this happens already,
> albeit lazily: if an ancestor limit is breached, siblings will enter
> memory pressure on their own once the next packet arrives for them.
>
> So no additional hierarchy code is needed. Remove the bogus stuff.
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2015-11-13 16:00 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 23:41 [PATCH 00/14] mm: memcontrol: account socket memory in unified hierarchy Johannes Weiner
2015-11-12 23:41 ` [PATCH 01/14] mm: memcontrol: export root_mem_cgroup Johannes Weiner
[not found] ` <1447371693-25143-2-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2015-11-13 15:59 ` David Miller
2015-11-14 12:17 ` Vladimir Davydov
2015-11-12 23:41 ` [PATCH 02/14] mm: vmscan: simplify memcg vs. global shrinker invocation Johannes Weiner
2015-11-13 15:59 ` David Miller
2015-11-14 12:36 ` Vladimir Davydov
2015-11-14 15:06 ` Johannes Weiner
2015-11-12 23:41 ` [PATCH 03/14] net: tcp_memcontrol: properly detect ancestor socket pressure Johannes Weiner
2015-11-13 16:00 ` David Miller
[not found] ` <1447371693-25143-4-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2015-11-14 12:45 ` Vladimir Davydov
2015-11-14 15:15 ` Johannes Weiner
2015-11-12 23:41 ` [PATCH 04/14] net: tcp_memcontrol: remove bogus hierarchy pressure propagation Johannes Weiner
2015-11-13 16:00 ` David Miller [this message]
2015-11-20 9:07 ` Vladimir Davydov
2015-11-12 23:41 ` [PATCH 05/14] net: tcp_memcontrol: protect all tcp_memcontrol calls by jump-label Johannes Weiner
[not found] ` <1447371693-25143-6-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2015-11-13 16:01 ` David Miller
2015-11-14 16:33 ` Vladimir Davydov
2015-11-16 17:52 ` Johannes Weiner
2015-11-12 23:41 ` [PATCH 06/14] net: tcp_memcontrol: remove dead per-memcg count of allocated sockets Johannes Weiner
2015-11-13 16:01 ` David Miller
2015-11-20 9:48 ` Vladimir Davydov
2015-11-12 23:41 ` [PATCH 07/14] net: tcp_memcontrol: simplify the per-memcg limit access Johannes Weiner
2015-11-20 9:51 ` Vladimir Davydov
2015-11-12 23:41 ` [PATCH 08/14] net: tcp_memcontrol: sanitize tcp memory accounting callbacks Johannes Weiner
2015-11-13 4:53 ` Eric Dumazet
[not found] ` <1447390418.22599.34.camel-XN9IlZ5yJG9HTL0Zs8A6p/gx64E7kk8eUsxypvmhUTTZJqsBc5GL+g@public.gmane.org>
2015-11-13 5:44 ` Johannes Weiner
2015-11-20 10:58 ` Vladimir Davydov
2015-11-20 18:42 ` Johannes Weiner
2015-11-12 23:41 ` [PATCH 09/14] net: tcp_memcontrol: simplify linkage between socket and page counter Johannes Weiner
2015-11-20 12:42 ` Vladimir Davydov
2015-11-20 18:56 ` Johannes Weiner
2015-11-23 9:36 ` Vladimir Davydov
2015-11-23 18:20 ` Johannes Weiner
[not found] ` <20151123182037.GE13000-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2015-11-24 13:43 ` Vladimir Davydov
2015-11-12 23:41 ` [PATCH 10/14] mm: memcontrol: generalize the socket accounting jump label Johannes Weiner
2015-11-13 10:43 ` Michal Hocko
2015-11-14 13:29 ` Vladimir Davydov
2015-11-12 23:41 ` [PATCH 11/14] mm: memcontrol: do not account memory+swap on unified hierarchy Johannes Weiner
2015-11-13 10:37 ` Michal Hocko
2015-11-14 13:23 ` Vladimir Davydov
2015-11-12 23:41 ` [PATCH 12/14] mm: memcontrol: move socket code for unified hierarchy accounting Johannes Weiner
2015-11-20 12:44 ` Vladimir Davydov
2015-11-12 23:41 ` [PATCH 13/14] mm: memcontrol: account socket memory in unified hierarchy memory controller Johannes Weiner
2015-11-16 15:59 ` Michal Hocko
[not found] ` <20151116155923.GH14116-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2015-11-16 18:18 ` Johannes Weiner
2015-11-18 16:22 ` Michal Hocko
2015-11-18 21:48 ` Johannes Weiner
2015-11-19 13:50 ` Michal Hocko
[not found] ` <20151119135023.GH8494-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2015-11-19 16:52 ` Johannes Weiner
[not found] ` <1447371693-25143-14-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2015-11-20 13:10 ` Vladimir Davydov
2015-11-20 19:25 ` Johannes Weiner
[not found] ` <20151120192506.GD5623-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2015-11-23 10:00 ` Vladimir Davydov
2015-11-23 19:31 ` Johannes Weiner
2015-11-12 23:41 ` [PATCH 14/14] mm: memcontrol: hook up vmpressure to socket pressure Johannes Weiner
2015-11-15 13:54 ` Vladimir Davydov
2015-11-16 18:53 ` Johannes Weiner
[not found] ` <20151116185316.GC32544-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2015-11-17 20:18 ` Vladimir Davydov
2015-11-17 22:22 ` Johannes Weiner
[not found] ` <20151117222217.GA20394-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2015-11-18 16:02 ` Vladimir Davydov
2015-11-18 18:27 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151113.110026.2097026445648423318.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=tj@kernel.org \
--cc=vdavydov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).