From: Ido Schimmel <idosch@mellanox.com>
To: Sander Eikelenboom <linux@eikelenboom.it>
Cc: <netdev@vger.kernel.org>, <stephen@networkplumber.org>,
<davem@davemloft.net>, <eladr@mellanox.com>,
Jiri Pirko <jiri@mellanox.com>, <nikolay@cumulusnetworks.com>
Subject: Re: [PATCH net] switchdev: bridge: Check return code is not EOPNOTSUPP
Date: Fri, 13 Nov 2015 14:43:19 +0200 [thread overview]
Message-ID: <20151113124319.GA31426@colbert.Home> (raw)
In-Reply-To: <f9593252b8a9d4733dfa7d22dd71d803@eikelenboom.it>
Fri, Nov 13, 2015 at 02:34:45PM IST, linux@eikelenboom.it wrote:
>On 2015-11-13 12:06, Ido Schimmel wrote:
>> When NET_SWITCHDEV=n, switchdev_port_attr_set simply returns
>> EOPNOTSUPP.
>> In this case we should not emit errors and warnings to the kernel log.
>
>Hi Ido,
>
>Thanks for your patch!
>
>It fixes these:
>[ 207.245442] vif vif-1-0 vif1.0: failed to set HW ageing time
>[ 207.245443] xen_bridge: error setting offload STP state on
>port1(vif1.0)
>
>But i still have these:
>[ 335.412194] vif19.0-emu: set_features() failed (-1); wanted
>0x00000080000048c1, left 0x00000080001b48c9
>[ 335.412204] vif19.0-emu: set_features() failed (-1); wanted
>0x00000080000048c1, left 0x00000080001b48c9
>[ 335.412311] vif19.0-emu: set_features() failed (-1); wanted
>0x00000080000248c9, left 0x00000080001b48c9
>[ 335.412319] vif19.0-emu: set_features() failed (-1); wanted
>0x00000080000048c1, left 0x00000080001b48c9
>[ 335.412326] vif19.0-emu: set_features() failed (-1); wanted
>0x00000080000048c1, left 0x00000080001b48c9
>[ 335.535955] vif vif-19-0 vif19.0: set_features() failed (-1); wanted
>0x0000000400004803, left 0x0000000400114813
>[ 335.535965] vif vif-19-0 vif19.0: set_features() failed (-1); wanted
>0x0000000400004803, left 0x0000000400114813
>[ 335.615392] vif vif-19-0 vif19.0: set_features() failed (-1); wanted
>0x0000000400004803, left 0x0000000400114813
>[ 335.615401] xen_bridge: set_features() failed (-1); wanted
>0x000000801fdb78c9, left 0x000000801fff78e9
>
Yes, this is a different issue and I see that Nik is already working on
it. Can you please try his patch?
http://patchwork.ozlabs.org/patch/544242/
next prev parent reply other threads:[~2015-11-13 12:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-13 11:06 [PATCH net] switchdev: bridge: Check return code is not EOPNOTSUPP Ido Schimmel
2015-11-13 12:34 ` Sander Eikelenboom
2015-11-13 12:43 ` Ido Schimmel [this message]
2015-11-13 13:34 ` Sander Eikelenboom
2015-11-16 19:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151113124319.GA31426@colbert.Home \
--to=idosch@mellanox.com \
--cc=davem@davemloft.net \
--cc=eladr@mellanox.com \
--cc=jiri@mellanox.com \
--cc=linux@eikelenboom.it \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).