From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net] net: fix feature changes on devices without ndo_set_features Date: Fri, 13 Nov 2015 15:00:25 +0100 Message-ID: <20151113140025.GC2143@nanopsycho.orion> References: <5645C0A5.2080506@cumulusnetworks.com> <1447422841-2333-1-git-send-email-razor@blackwall.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, davem@davemloft.net, Nikolay Aleksandrov , Jarod Wilson , Ido Schimmel , Sander Eikelenboom , Andy Gospodarek , Florian Fainelli To: Nikolay Aleksandrov Return-path: Received: from mail-wm0-f52.google.com ([74.125.82.52]:36467 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754669AbbKMOA3 (ORCPT ); Fri, 13 Nov 2015 09:00:29 -0500 Received: by wmww144 with SMTP id w144so29835805wmw.1 for ; Fri, 13 Nov 2015 06:00:27 -0800 (PST) Content-Disposition: inline In-Reply-To: <1447422841-2333-1-git-send-email-razor@blackwall.org> Sender: netdev-owner@vger.kernel.org List-ID: Fri, Nov 13, 2015 at 02:54:01PM CET, razor@blackwall.org wrote: >From: Nikolay Aleksandrov > >When __netdev_update_features() was updated to ensure some features are >disabled on new lower devices, an error was introduced for devices which >don't have the ndo_set_features() method set. Before we'll just set the >new features, but now we return an error and don't set them. Fix this by >returning the old behaviour and setting err to 0 when ndo_set_features >is not present. > >Fixes: e7868a85e1b2 ("net/core: ensure features get disabled on new lower devs") >CC: Jarod Wilson >CC: Jiri Pirko >CC: Ido Schimmel >CC: Sander Eikelenboom >CC: Andy Gospodarek >CC: Florian Fainelli >Signed-off-by: Nikolay Aleksandrov Reviewed-by: Jiri Pirko Thanks.