From: Jiri Pirko <jiri@resnulli.us>
To: Premkumar Jonnala <pjonnala@broadcom.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
andrew@lunn.ch, f.fainelli@gmail.com, idosch@mellanox.com,
nikolay@cumulusnetworks.com, sfeldma@gmail.com,
gospo@cumulusnetworks.com, davem@davemloft.net
Subject: Re: [PATCH] bonding: Offloading bonds to hardware
Date: Sat, 14 Nov 2015 10:39:20 +0100 [thread overview]
Message-ID: <20151114093920.GA2188@nanopsycho.orion> (raw)
In-Reply-To: <77EF4405DD4BB54AACCE7DB593DF6A9A9FD653@SJEXCHMB14.corp.ad.broadcom.com>
Thu, Nov 12, 2015 at 05:02:18PM CET, pjonnala@broadcom.com wrote:
>Packet forwarding to/from bond interfaces is done in software.
>
>This patch enables certain platforms to bridge traffic to/from
>bond interfaces in hardware. Notifications are sent out when
>the "active" slave set for a bond interface is updated in
>software. Platforms use the notifications to program the
>hardware accordingly. The changes have been verified to work
>with configured and 802.3ad bond interfaces.
>
>Signed-off-by: Premkumar Jonnala <pjonnala@broadcom.com>
This patch is wrong, in many different acpects. Leaving the submission
style, and no in-tree consumer aside, adding ndos for this thing is
unacceptable. It should be handled as a part of switchdev attrs.
Also, the solution should not be bonding-centric.
I have a patchset in my queue which does this correctly, for bond and team
using switchdev attr and with actual in-tree consumer, mlxsw driver.
I plan to send that soon after net-next opens.
Jiri
next prev parent reply other threads:[~2015-11-14 9:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 16:02 [PATCH] bonding: Offloading bonds to hardware Premkumar Jonnala
2015-11-12 17:08 ` Andrew Lunn
2015-11-14 9:40 ` Jiri Pirko
2015-11-13 18:38 ` Florian Fainelli
2015-11-13 19:10 ` David Miller
2015-11-16 6:12 ` Premkumar Jonnala
2015-11-16 6:51 ` David Miller
2015-11-16 6:49 ` Premkumar Jonnala
2015-11-16 6:54 ` David Miller
2015-11-16 6:10 ` Premkumar Jonnala
2015-11-13 21:11 ` Andrew Lunn
2015-11-16 6:15 ` Premkumar Jonnala
2015-11-14 9:39 ` Jiri Pirko [this message]
2015-11-15 5:51 ` John Fastabend
2015-11-15 9:01 ` Jiri Pirko
2015-11-16 16:24 ` John Fastabend
2015-11-16 6:48 ` Premkumar Jonnala
2015-11-16 7:46 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151114093920.GA2188@nanopsycho.orion \
--to=jiri@resnulli.us \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gospo@cumulusnetworks.com \
--cc=idosch@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=pjonnala@broadcom.com \
--cc=sfeldma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).