From: Stephen Hemminger <stephen@networkplumber.org>
To: Eli Cohen <eli@mellanox.com>
Cc: netdev@vger.kernel.org
Subject: mlx5 Coverity reported issues
Date: Mon, 16 Nov 2015 09:46:28 -0800 [thread overview]
Message-ID: <20151116094628.04d7ab3f@samsung9> (raw)
** CID 1056375: Error handling issues (CHECKED_RETURN)
/drivers/net/ethernet/mellanox/mlx5/core/cq.c: 133 in mlx5_core_create_cq()
________________________________________________________________________________________________________
*** CID 1056375: Error handling issues (CHECKED_RETURN)
/drivers/net/ethernet/mellanox/mlx5/core/cq.c: 133 in mlx5_core_create_cq()
127 return 0;
128
129 err_cmd:
130 memset(&din, 0, sizeof(din));
131 memset(&dout, 0, sizeof(dout));
132 din.hdr.opcode = cpu_to_be16(MLX5_CMD_OP_DESTROY_CQ);
>>> CID 1056375: Error handling issues (CHECKED_RETURN)
>>> Calling "mlx5_cmd_exec" without checking return value (as is done elsewhere 44 out of 46 times).
133 mlx5_cmd_exec(dev, &din, sizeof(din), &dout, sizeof(dout));
134 return err;
135 }
136 EXPORT_SYMBOL(mlx5_core_create_cq);
137
138 int mlx5_core_destroy_cq(struct mlx5_core_dev *dev, struct mlx5_core_cq *cq)
** CID 1056376: Error handling issues (CHECKED_RETURN)
/drivers/net/ethernet/mellanox/mlx5/core/qp.c: 242 in mlx5_core_create_qp()
________________________________________________________________________________________________________
*** CID 1056376: Error handling issues (CHECKED_RETURN)
/drivers/net/ethernet/mellanox/mlx5/core/qp.c: 242 in mlx5_core_create_qp()
236
237 err_cmd:
238 memset(&din, 0, sizeof(din));
239 memset(&dout, 0, sizeof(dout));
240 din.hdr.opcode = cpu_to_be16(MLX5_CMD_OP_DESTROY_QP);
241 din.qpn = cpu_to_be32(qp->qpn);
>>> CID 1056376: Error handling issues (CHECKED_RETURN)
>>> Calling "mlx5_cmd_exec" without checking return value (as is done elsewhere 44 out of 46 times).
242 mlx5_cmd_exec(dev, &din, sizeof(din), &out, sizeof(dout));
243
244 return err;
245 }
246 EXPORT_SYMBOL_GPL(mlx5_core_create_qp);
247
reply other threads:[~2015-11-16 17:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151116094628.04d7ab3f@samsung9 \
--to=stephen@networkplumber.org \
--cc=eli@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox