From: Rob Herring <robh@kernel.org>
To: huangdaode <huangdaode@hisilicon.com>
Cc: davem@davemloft.net, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
liguozhu@hisilicon.com, Yisen.Zhuang@huawei.com,
dingtianhong@huawei.com, zhangfei.gao@linaro.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
linuxarm@huawei.com, salil.mehta@huawei.com,
kenneth-lee-2012@foxmail.com, xuwei5@hisilicon.com,
lisheng011@huawei.com
Subject: Re: [PATCH v2 net-next] net: hisilicon: fix binding document of mdio
Date: Mon, 16 Nov 2015 09:20:51 -0600 [thread overview]
Message-ID: <20151116152051.GA7183@rob-hp-laptop> (raw)
In-Reply-To: <1447666704-200773-1-git-send-email-huangdaode@hisilicon.com>
On Mon, Nov 16, 2015 at 05:38:24PM +0800, huangdaode wrote:
> This patch explains the occasion of "hisilcon,mdio" and
> "hisilicon,hns-mdio" according to Arnd's comments.
> and reformat it according to comments from Rob<robh@kernel.org>.
>
> chang log:
>
> v2:
> 1) reformat the style.
> 2) make it more clearity.
>
> v1:
> initial version.
>
> Signed-off-by: huangdaode <huangdaode@hisilicon.com>
> ---
> Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt b/Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt
> index 9c23fdf..4942d20 100644
> --- a/Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt
> +++ b/Documentation/devicetree/bindings/net/hisilicon-hns-mdio.txt
> @@ -1,7 +1,12 @@
> Hisilicon MDIO bus controller
>
> Properties:
> -- compatible: "hisilicon,mdio","hisilicon,hns-mdio".
> +- compatible: can be one of:
> + "hisilicon,hns-mdio"
> + "hisilicon,mdio"
> + "hisilicon,hns-mdio" is recommendly to be used for hip05 and later SOCs,
s/recommendly/recommended/
> + while "hisilicon,mdio" is optional for backwards compatibility, only
> + support for hip04 Soc.
...compatibility only on hip04 SOC.
> - reg: The base address of the MDIO bus controller register bank.
> - #address-cells: Must be <1>.
> - #size-cells: Must be <0>. MDIO addresses have no size component.
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-11-16 15:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 9:38 [PATCH v2 net-next] net: hisilicon: fix binding document of mdio huangdaode
2015-11-16 9:38 ` Arnd Bergmann
2015-11-18 1:42 ` huangdaode
2015-11-16 15:20 ` Rob Herring [this message]
2015-11-18 1:43 ` huangdaode
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151116152051.GA7183@rob-hp-laptop \
--to=robh@kernel.org \
--cc=Yisen.Zhuang@huawei.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dingtianhong@huawei.com \
--cc=galak@codeaurora.org \
--cc=huangdaode@hisilicon.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kenneth-lee-2012@foxmail.com \
--cc=liguozhu@hisilicon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lisheng011@huawei.com \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=salil.mehta@huawei.com \
--cc=xuwei5@hisilicon.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).