From: Johannes Weiner <hannes@cmpxchg.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: David Miller <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>,
Vladimir Davydov <vdavydov@virtuozzo.com>,
Tejun Heo <tj@kernel.org>,
netdev@vger.kernel.org, linux-mm@kvack.org,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH 13/14] mm: memcontrol: account socket memory in unified hierarchy memory controller
Date: Wed, 18 Nov 2015 16:48:22 -0500 [thread overview]
Message-ID: <20151118214822.GA1365@cmpxchg.org> (raw)
In-Reply-To: <20151118162256.GK19145@dhcp22.suse.cz>
On Wed, Nov 18, 2015 at 05:22:56PM +0100, Michal Hocko wrote:
> On Mon 16-11-15 13:18:10, Johannes Weiner wrote:
> > What load would you test and what would be the baseline to compare it
> > to?
>
> It seems like netperf with a stream load running in a memcg with no
> limits vs. in root memcg (and no other cgroups) should give at least a
> hint about the runtime overhead, no?
Comparing root vs. dedicated group generally doesn't make sense since
you either need containment or you don't. It makes more sense to test
both times inside a memory-controlled cgroup, one with a regular boot,
one with cgroup.memory=nosocket.
So I ran perf record -g -a netperf -t TCP_STREAM multiple times inside
a memory-controlled cgroup, but mostly mem_cgroup_charge_skmem() does
not show up in the profile at all. Once it was there with 0.00%.
I ran another test that downloads the latest kernel image from
kernel.org at 13MB/s (on my i5 laptop) and it looks like this:
0.02% 0.01% irq/44-iwlwifi [kernel.kallsyms] [k] mem_cgroup_charge_skmem
|
---mem_cgroup_charge_skmem
__sk_mem_schedule
tcp_try_rmem_schedule
tcp_data_queue
tcp_rcv_established
tcp_v4_do_rcv
tcp_v4_rcv
ip_local_deliver
ip_rcv
__netif_receive_skb_core
__netif_receive_skb
netif_receive_skb_internal
napi_gro_complete
The runs vary too much for this to be measurable in elapsed time.
next prev parent reply other threads:[~2015-11-18 21:48 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 23:41 [PATCH 00/14] mm: memcontrol: account socket memory in unified hierarchy Johannes Weiner
2015-11-12 23:41 ` [PATCH 01/14] mm: memcontrol: export root_mem_cgroup Johannes Weiner
[not found] ` <1447371693-25143-2-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2015-11-13 15:59 ` David Miller
2015-11-14 12:17 ` Vladimir Davydov
2015-11-12 23:41 ` [PATCH 02/14] mm: vmscan: simplify memcg vs. global shrinker invocation Johannes Weiner
2015-11-13 15:59 ` David Miller
2015-11-14 12:36 ` Vladimir Davydov
2015-11-14 15:06 ` Johannes Weiner
2015-11-12 23:41 ` [PATCH 03/14] net: tcp_memcontrol: properly detect ancestor socket pressure Johannes Weiner
2015-11-13 16:00 ` David Miller
[not found] ` <1447371693-25143-4-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2015-11-14 12:45 ` Vladimir Davydov
2015-11-14 15:15 ` Johannes Weiner
2015-11-12 23:41 ` [PATCH 04/14] net: tcp_memcontrol: remove bogus hierarchy pressure propagation Johannes Weiner
2015-11-13 16:00 ` David Miller
2015-11-20 9:07 ` Vladimir Davydov
2015-11-12 23:41 ` [PATCH 05/14] net: tcp_memcontrol: protect all tcp_memcontrol calls by jump-label Johannes Weiner
[not found] ` <1447371693-25143-6-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2015-11-13 16:01 ` David Miller
2015-11-14 16:33 ` Vladimir Davydov
2015-11-16 17:52 ` Johannes Weiner
2015-11-12 23:41 ` [PATCH 06/14] net: tcp_memcontrol: remove dead per-memcg count of allocated sockets Johannes Weiner
2015-11-13 16:01 ` David Miller
2015-11-20 9:48 ` Vladimir Davydov
2015-11-12 23:41 ` [PATCH 07/14] net: tcp_memcontrol: simplify the per-memcg limit access Johannes Weiner
2015-11-20 9:51 ` Vladimir Davydov
2015-11-12 23:41 ` [PATCH 08/14] net: tcp_memcontrol: sanitize tcp memory accounting callbacks Johannes Weiner
2015-11-13 4:53 ` Eric Dumazet
[not found] ` <1447390418.22599.34.camel-XN9IlZ5yJG9HTL0Zs8A6p/gx64E7kk8eUsxypvmhUTTZJqsBc5GL+g@public.gmane.org>
2015-11-13 5:44 ` Johannes Weiner
2015-11-20 10:58 ` Vladimir Davydov
2015-11-20 18:42 ` Johannes Weiner
2015-11-12 23:41 ` [PATCH 09/14] net: tcp_memcontrol: simplify linkage between socket and page counter Johannes Weiner
2015-11-20 12:42 ` Vladimir Davydov
2015-11-20 18:56 ` Johannes Weiner
2015-11-23 9:36 ` Vladimir Davydov
2015-11-23 18:20 ` Johannes Weiner
[not found] ` <20151123182037.GE13000-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2015-11-24 13:43 ` Vladimir Davydov
2015-11-12 23:41 ` [PATCH 10/14] mm: memcontrol: generalize the socket accounting jump label Johannes Weiner
2015-11-13 10:43 ` Michal Hocko
2015-11-14 13:29 ` Vladimir Davydov
2015-11-12 23:41 ` [PATCH 11/14] mm: memcontrol: do not account memory+swap on unified hierarchy Johannes Weiner
2015-11-13 10:37 ` Michal Hocko
2015-11-14 13:23 ` Vladimir Davydov
2015-11-12 23:41 ` [PATCH 12/14] mm: memcontrol: move socket code for unified hierarchy accounting Johannes Weiner
2015-11-20 12:44 ` Vladimir Davydov
2015-11-12 23:41 ` [PATCH 13/14] mm: memcontrol: account socket memory in unified hierarchy memory controller Johannes Weiner
2015-11-16 15:59 ` Michal Hocko
[not found] ` <20151116155923.GH14116-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2015-11-16 18:18 ` Johannes Weiner
2015-11-18 16:22 ` Michal Hocko
2015-11-18 21:48 ` Johannes Weiner [this message]
2015-11-19 13:50 ` Michal Hocko
[not found] ` <20151119135023.GH8494-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2015-11-19 16:52 ` Johannes Weiner
[not found] ` <1447371693-25143-14-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2015-11-20 13:10 ` Vladimir Davydov
2015-11-20 19:25 ` Johannes Weiner
[not found] ` <20151120192506.GD5623-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2015-11-23 10:00 ` Vladimir Davydov
2015-11-23 19:31 ` Johannes Weiner
2015-11-12 23:41 ` [PATCH 14/14] mm: memcontrol: hook up vmpressure to socket pressure Johannes Weiner
2015-11-15 13:54 ` Vladimir Davydov
2015-11-16 18:53 ` Johannes Weiner
[not found] ` <20151116185316.GC32544-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2015-11-17 20:18 ` Vladimir Davydov
2015-11-17 22:22 ` Johannes Weiner
[not found] ` <20151117222217.GA20394-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2015-11-18 16:02 ` Vladimir Davydov
2015-11-18 18:27 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151118214822.GA1365@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tj@kernel.org \
--cc=vdavydov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).