From: Pavel Machek <pavel@ucw.cz>
To: peppe.cavallaro@st.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: trivial@kernel.org
Subject: stmmac: add a warning when aliases are not present in device tree
Date: Mon, 23 Nov 2015 16:46:48 +0100 [thread overview]
Message-ID: <20151123154648.GA16978@amd> (raw)
If aliases are not present in device tree, stmmac_platform.c will
happily assign bus_id of 0 to all the ethernet interfaces, resulting
in hard to debug problems.
At least warn the user about the problem.
Signed-off-by: Pavel Machek <pavel@denx.de>
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
index f9b42f1..ee8aa26 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
@@ -161,8 +161,10 @@ static int stmmac_probe_config_dt(struct platform_device *pdev,
plat->max_speed = -1;
plat->bus_id = of_alias_get_id(np, "ethernet");
- if (plat->bus_id < 0)
+ if (plat->bus_id < 0) {
+ dev_warn(&pdev->dev, "no aliases for ethernet; multiple ethernets will break\n");
plat->bus_id = 0;
+ }
/* Default to phy auto-detection */
plat->phy_addr = -1;
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next reply other threads:[~2015-11-23 15:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 15:46 Pavel Machek [this message]
2015-11-23 23:35 ` stmmac: add a warning when aliases are not present in device tree Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151123154648.GA16978@amd \
--to=pavel@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).