public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemming@brocade.com>
To: Phil Sutter <phil@nwl.cc>
Cc: <netdev@vger.kernel.org>
Subject: Re: [iproute PATCH] iproute: restrict hoplimit values to be in range [1;255]
Date: Mon, 23 Nov 2015 15:48:44 -0800	[thread overview]
Message-ID: <20151123154844.5466a6e3@xeon-e3> (raw)
In-Reply-To: <1447160049-29214-1-git-send-email-phil@nwl.cc>

On Tue, 10 Nov 2015 13:54:09 +0100
Phil Sutter <phil@nwl.cc> wrote:

> Technically, the range of possible hoplimit values are defined by IPv4
> and IPv6 header formats. Both define the field to be eight bits in size,
> which leads to a value range of [0;255]. Setting a packet's hoplimit
> field to 0 though makes not much sense, as the next hop would
> immediately drop the packet. Therefore Linux uses 0 as a special value
> indicating to use the system's default hoplimit (configurable via
> sysctl). In iproute, setting the hoplimit of a route to 0 is equivalent
> to omitting the hoplimit parameter alltogether, so it is not necessary
> to allow that value to be specified.
> 
> Signed-off-by: Phil Sutter <phil@nwl.cc>

Even though it doesn't make much sense to set hoplimit of 0;
I am concerned that some user is doing that now, and changing this
would break a working (but not optimum or sane) configuration.
Especially if actual config is auto-generated.

  reply	other threads:[~2015-11-23 23:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-10 12:54 [iproute PATCH] iproute: restrict hoplimit values to be in range [1;255] Phil Sutter
2015-11-23 23:48 ` Stephen Hemminger [this message]
2015-11-24 14:45   ` [iproute PATCH v2] iproute: restrict hoplimit values to be in range [0;255] Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151123154844.5466a6e3@xeon-e3 \
    --to=shemming@brocade.com \
    --cc=netdev@vger.kernel.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox