From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, simon.horman@netronome.com,
rolf.neugebauer@netronome.com
Subject: Re: [PATCH net-next v3 2/2] net: add driver for Netronome NFP4000/NFP6000 NIC VFs
Date: Tue, 24 Nov 2015 19:53:05 +0000 [thread overview]
Message-ID: <20151124195305.61524d83@jkicinski-Precision-T1700> (raw)
In-Reply-To: <20151124.142531.1333743019199613941.davem@davemloft.net>
On Tue, 24 Nov 2015 14:25:31 -0500 (EST), David Miller wrote:
> From: Jakub Kicinski <jakub.kicinski@netronome.com>
> Date: Mon, 23 Nov 2015 11:04:57 +0000
>
> > +#ifdef CONFIG_NFP_NET_DEBUG
> > +#define DEBUG
> > +#endif
>
> Do not design ad-hoc debug logging facilities locally in your driver,
> and instead use the existing tree wide facilities as they were designed
> to be used so that any user can get debugging logs simply by turning it
> on at run time rather than having the change magic config options in
> their kernel.
True. I picked this habit up from the rt2x00 driver long time ago.
Now I see nobody else is doing such things...
next prev parent reply other threads:[~2015-11-24 19:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 18:15 [PATCHv2 0/2] Netronome NFP4000/NFP6000 NIC VF driver Jakub Kicinski
2015-10-27 18:15 ` [PATCHv2 1/2] pci_ids: add Netronome Systems vendor Jakub Kicinski
2015-10-27 18:15 ` [PATCHv2 2/2] net: add driver for Netronome NFP4000/NFP6000 NIC VFs Jakub Kicinski
2015-10-30 10:27 ` David Miller
2015-11-23 11:04 ` [PATCH net-next v3 0/2] Netronome NFP4000/NFP6000 NIC VF driver Jakub Kicinski
2015-11-23 11:04 ` [PATCH net-next v3 1/2] pci_ids: add Netronome Systems vendor Jakub Kicinski
2015-11-23 11:04 ` [PATCH net-next v3 2/2] net: add driver for Netronome NFP4000/NFP6000 NIC VFs Jakub Kicinski
2015-11-24 19:25 ` David Miller
2015-11-24 19:53 ` Jakub Kicinski [this message]
2015-11-25 15:39 ` [PATCH net-next v4 0/2] Netronome NFP4000/NFP6000 NIC VF driver Jakub Kicinski
2015-11-25 15:39 ` [PATCH net-next v4 1/2] pci_ids: add Netronome Systems vendor Jakub Kicinski
2015-11-25 15:39 ` [PATCH net-next v4 2/2] net: add driver for Netronome NFP4000/NFP6000 NIC VFs Jakub Kicinski
2015-11-30 15:42 ` David Miller
2015-12-01 14:55 ` [PATCH net-next v5 0/2] Netronome NFP4000/NFP6000 NIC VF driver Jakub Kicinski
2015-12-01 14:55 ` [PATCH net-next v5 1/2] pci_ids: add Netronome Systems vendor Jakub Kicinski
2015-12-01 14:55 ` [PATCH net-next v5 2/2] net: add driver for Netronome NFP4000/NFP6000 NIC VFs Jakub Kicinski
2015-12-03 19:18 ` [PATCH net-next v5 0/2] Netronome NFP4000/NFP6000 NIC VF driver David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151124195305.61524d83@jkicinski-Precision-T1700 \
--to=jakub.kicinski@netronome.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rolf.neugebauer@netronome.com \
--cc=simon.horman@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox