From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Aring Subject: Re: [RFCv2 bluetooth-next 2/3] ipv6: add ipv6_addr_prefix_cpy Date: Wed, 25 Nov 2015 19:17:17 +0100 Message-ID: <20151125181713.GC4652@omega> References: <1447799594-6050-1-git-send-email-alex.aring@gmail.com> <1447799594-6050-3-git-send-email-alex.aring@gmail.com> <5655E50C.5090906@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: linux-wpan-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, mcr-SWp7JaYWvAQV+D8aMU/kSg@public.gmane.org, lukasz.duda-hR+23Fw+YnFSHonuZl5R5Q@public.gmane.org, martin.gergeleit-6wGqcYweBVc@public.gmane.org, "David S . Miller" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy To: Stefan Schmidt Return-path: Content-Disposition: inline In-Reply-To: <5655E50C.5090906-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> Sender: linux-bluetooth-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Wed, Nov 25, 2015 at 05:42:52PM +0100, Stefan Schmidt wrote: > Hello. > > On 17/11/15 23:33, Alexander Aring wrote: > >This patch adds a static inline function ipv6_addr_prefix_cpy which > >copies a ipv6 address prefix(argument pfx) into the ipv6 address prefix. > >The prefix len is given by plen as bits. This function mainly based on > >ipv6_addr_prefix which copies one address prefix from address into a new > >ipv6 address destination and zero all other address bits. > > > >The difference is that ipv6_addr_prefix_cpy don't get a prefix from an > >ipv6 address, it sets a prefix to an ipv6 address with keeping other > >address bits. The use case is for context based address compression > >inside 6LoWPAN IPHC header which keeping ipv6 prefixes inside a context > >table to lookup address-bits without sending them. > > > >Cc: David S. Miller > >Cc: Alexey Kuznetsov > >Cc: James Morris > >Cc: Hideaki YOSHIFUJI > >Cc: Patrick McHardy > >Signed-off-by: Alexander Aring > >--- > > include/net/ipv6.h | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > >diff --git a/include/net/ipv6.h b/include/net/ipv6.h > >index e1a10b0..9d38fc2 100644 > >--- a/include/net/ipv6.h > >+++ b/include/net/ipv6.h > >@@ -382,6 +382,21 @@ static inline void ipv6_addr_prefix(struct in6_addr *pfx, > > pfx->s6_addr[o] = addr->s6_addr[o] & (0xff00 >> b); > > } > >+static inline void ipv6_addr_prefix_cpy(struct in6_addr *addr, > >+ const struct in6_addr *pfx, > >+ int plen) > >+{ > > Naming it ipv6_addr_prefix_cop, as Sergei suggested, would be easier to > read. ok. > >+ /* caller must guarantee 0 <= plen <= 128 */ > >+ int o = plen >> 3, > >+ b = plen & 0x7; > >+ > > Any reason you are not doing the memset here before memcpy like it is done > in ipv6_addr_prefi()? ipv6_addr_prefix is more a "getter" for a prefix from an address. The destination address (which should be the result) will memset the whole address before copy the prefix from address to it. THe ipv6_addr_prefix_copy will set a prefix given by second parameter pfx and set the prefix to the address (given by first parameter). Maybe the ipv6_addr_prefix could call: 1. memset(pfx, sizeof...) 2. ipv6_addr_prefix_copy(pfx, addr, plen); but ipv6_addr_prefix_copy need to care about other bits which are set at destination address, if (plen/8 != 0). I don't want to touch ipv6_addr_prefix function and slow-down some mechanism. - Alex