From: Mark Brown <broonie@kernel.org>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: linaro-kernel@lists.linaro.org,
kernel-build-reports@lists.linaro.org, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
linux-next@vger.kernel.org
Subject: Re: next-20151126 build: 3 failures 15 warnings (next-20151126)
Date: Thu, 26 Nov 2015 17:03:00 +0000 [thread overview]
Message-ID: <20151126170300.GH1929@sirena.org.uk> (raw)
In-Reply-To: <87lh9kn1dz.fsf@kamboji.qca.qualcomm.com>
[-- Attachment #1: Type: text/plain, Size: 760 bytes --]
On Thu, Nov 26, 2015 at 06:58:32PM +0200, Kalle Valo wrote:
> Mark Brown <broonie@kernel.org> writes:
> > No, I didn't make much effort to check though since the use of ifdef was
> > clearly a bug waiting to happen anyway, I was more surprised it worked
> > at all than anything.
> Michal Marek explains[1] that this is due to commit cf4f21938e13
> ("kbuild: Allow to specify composite modules with modname-m") and has
> nothing to do with the wireless drivers reorganisation. I'll drop this
> patch as Michal will apply his fix to the kbuild tree.
It still ought to be fixed regardless of why it showed up - the
intention of the code is that we build the real thermal code regardless
of if that's modular or not but that's not what the code actually does.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-11-26 17:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1a1sVV-00079q-My@optimist>
2015-11-26 11:59 ` next-20151126 build: 3 failures 15 warnings (next-20151126) Mark Brown
2015-11-26 12:15 ` Mark Brown
[not found] ` <20151126121551.GE1929-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-11-26 12:39 ` Kalle Valo
2015-11-26 13:22 ` Mark Brown
2015-11-26 16:58 ` Kalle Valo
2015-11-26 17:03 ` Mark Brown [this message]
2015-11-26 18:34 ` Kalle Valo
[not found] ` <878u5kmwya.fsf-HodKDYzPHsUD5k0oWYwrnHL1okKdlPRT@public.gmane.org>
2015-11-26 20:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151126170300.GH1929@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ath10k@lists.infradead.org \
--cc=kernel-build-reports@lists.linaro.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).